Procházet zdrojové kódy

Stop using 'Review manager requests', adjust some minor advice bits. (#293)

Jon Meow před 5 roky
rodič
revize
23009d3b06
2 změnil soubory, kde provedl 17 přidání a 15 odebrání
  1. 9 8
      docs/project/evolution.md
  2. 8 7
      docs/project/review_managers.md

+ 9 - 8
docs/project/evolution.md

@@ -374,10 +374,9 @@ discussion points thus far. Links to prior topics should be included.
 #### Request a review manager
 
 Once discussion settles down and all comments have been resolved, the author
-should request a review manager by creating a
-`Evolution > Review manager requests` topic. A review manager should respond
-within a day or two. This may not be needed if a review manager has already
-taken ownership.
+should ask for a review manager either on the RFC topic with `@review_managers`
+or on `#proposals` in Discord Chat. A review manager should respond within a day
+or two. This may not be needed if a review manager has already taken ownership.
 
 The review manager is responsible for validating that the proposal is ready for
 the reviewing team to make a decision. They will ensure that at least a couple
@@ -394,12 +393,12 @@ the comment period by posting another message to the "Evolution > RFCs" topic.
 
 -   **Author**:
     -   Ensure all comments are resolved.
-    -   Create a `Evolution > Review manager requests` topic asking for a review
-        manager, providing a link to the proposal's GitHub pull request.
-        -   Add the topic's link to the GitHub pull request.
+    -   Ask for a review manager on either the RFC topic or `#proposals` in
+        Discord chat.
 -   **Review manager**:
     -   Ask reviewing team members to review the proposal when needed.
-    -   Double-check that comment threads are addressed by the proposal.
+    -   Double-check for comment threads that the author may have missed before
+        proceeding.
     -   [Update](review_managers.md#comment-deadline) the `Evolution > RFCs`
         topic with a last call for comments.
     -   Add the `comment deadline` label to the GitHub pull request.
@@ -454,6 +453,8 @@ make decisions.
 -   **Author**:
     -   Respond to comments.
 -   **Review manager:**
+    -   Double-check for comment threads that the author may have missed before
+        proceeding.
     -   Replace the GitHub pull request's `RFC` and `comment deadline` labels
         with `needs decision`.
     -   [Create](review_managers.md#decision-request) an

+ 8 - 7
docs/project/review_managers.md

@@ -24,6 +24,10 @@ process.
 
 ## Templates
 
+The list of links for the proposal PR, RFC topic, etc., should be maintained as
+a comment on the proposal PR. Try to keep this up-to-date, and copy-paste it
+when adding links to Discourse Forum topics.
+
 ### Comment deadline
 
 When an RFC approaches readiness for a decision, the review manager must post a
@@ -53,10 +57,8 @@ titled "Request for decision: PROPOSAL":
 ```markdown
 @core_team: Please provide a decision on "PROPOSAL".
 
-Links:
-
--   [Proposal PR](LINK)
--   [RFC topic](LINK)
+TODO: Copy links from the proposal PR, add add a link to the decision topic when
+created.
 
 Please focus on affirm, object, and stand aside comments in this topic; other
 things specific to reaching consensus may be included. Affirm and object
@@ -95,9 +97,8 @@ titled "[DECISION] PROPOSAL":
 
 Please read the [formal decision PR](LINK) for details.
 
--   [Proposal PR](LINK)
--   [RFC topic](LINK)
--   [Decision topic](link)
+TODO: Copy links from the proposal PR, and add links to the decision PR and
+announcement topic when created.
 
 This decision is now entering the
 [decision comment period](https://carbon-lang.dev/docs/project/evolution.html#community-comments-on-proposal-decision),