Selaa lähdekoodia

Use `llvm::reverse()` instead of `pop_back_val()` in `ImportDeclAndDependencies()` (#5831)

This is more explicit and similar to what we do in `MapType()`.
Boaz Brickner 9 kuukautta sitten
vanhempi
sitoutus
68ee3d5021
1 muutettua tiedostoa jossa 7 lisäystä ja 4 poistoa
  1. 7 4
      toolchain/check/import_cpp.cpp

+ 7 - 4
toolchain/check/import_cpp.cpp

@@ -1143,10 +1143,13 @@ static auto ImportDeclAndDependencies(Context& context, SemIR::LocId loc_id,
 
 
   // Import dependencies in reverse order.
   // Import dependencies in reverse order.
   auto inst_id = SemIR::InstId::None;
   auto inst_id = SemIR::InstId::None;
-  do {
-    inst_id = ImportDeclAfterDependencies(context, loc_id,
-                                          clang_decls.pop_back_val());
-  } while (inst_id.has_value() && !clang_decls.empty());
+  for (clang::Decl* clang_decl_to_import : llvm::reverse(clang_decls)) {
+    inst_id =
+        ImportDeclAfterDependencies(context, loc_id, clang_decl_to_import);
+    if (!inst_id.has_value()) {
+      break;
+    }
+  }
 
 
   return inst_id;
   return inst_id;
 }
 }