Prechádzať zdrojové kódy

Move Lower::HandleCall out to its own file. (#4116)

This is over half of handle.cpp right now, due to builtin function
logic.
Jon Ross-Perkins 1 rok pred
rodič
commit
a4ef5dd591

+ 1 - 0
toolchain/lower/BUILD

@@ -47,6 +47,7 @@ cc_library(
         "//toolchain/base:kind_switch",
         "//toolchain/sem_ir:entry_point",
         "//toolchain/sem_ir:file",
+        "//toolchain/sem_ir:ids",
         "//toolchain/sem_ir:inst",
         "//toolchain/sem_ir:inst_kind",
         "//toolchain/sem_ir:inst_namer",

+ 0 - 317
toolchain/lower/handle.cpp

@@ -170,323 +170,6 @@ auto HandleBranchWithArg(FunctionContext& context, SemIR::InstId /*inst_id*/,
   context.builder().ClearInsertionPoint();
 }
 
-// Get the predicate to use for an `icmp` instruction generated for the
-// specified builtin.
-static auto GetBuiltinICmpPredicate(SemIR::BuiltinFunctionKind builtin_kind,
-                                    bool is_signed)
-    -> llvm::CmpInst::Predicate {
-  switch (builtin_kind) {
-    case SemIR::BuiltinFunctionKind::IntEq:
-      return llvm::CmpInst::ICMP_EQ;
-    case SemIR::BuiltinFunctionKind::IntNeq:
-      return llvm::CmpInst::ICMP_NE;
-    case SemIR::BuiltinFunctionKind::IntLess:
-      return is_signed ? llvm::CmpInst::ICMP_SLT : llvm::CmpInst::ICMP_ULT;
-    case SemIR::BuiltinFunctionKind::IntLessEq:
-      return is_signed ? llvm::CmpInst::ICMP_SLE : llvm::CmpInst::ICMP_ULE;
-    case SemIR::BuiltinFunctionKind::IntGreater:
-      return is_signed ? llvm::CmpInst::ICMP_SGT : llvm::CmpInst::ICMP_UGT;
-    case SemIR::BuiltinFunctionKind::IntGreaterEq:
-      return is_signed ? llvm::CmpInst::ICMP_SGE : llvm::CmpInst::ICMP_UGE;
-    default:
-      CARBON_FATAL() << "Unexpected builtin kind " << builtin_kind;
-  }
-}
-
-// Get the predicate to use for an `fcmp` instruction generated for the
-// specified builtin.
-static auto GetBuiltinFCmpPredicate(SemIR::BuiltinFunctionKind builtin_kind)
-    -> llvm::CmpInst::Predicate {
-  switch (builtin_kind) {
-    case SemIR::BuiltinFunctionKind::FloatEq:
-      return llvm::CmpInst::FCMP_OEQ;
-    case SemIR::BuiltinFunctionKind::FloatNeq:
-      return llvm::CmpInst::FCMP_ONE;
-    case SemIR::BuiltinFunctionKind::FloatLess:
-      return llvm::CmpInst::FCMP_OLT;
-    case SemIR::BuiltinFunctionKind::FloatLessEq:
-      return llvm::CmpInst::FCMP_OLE;
-    case SemIR::BuiltinFunctionKind::FloatGreater:
-      return llvm::CmpInst::FCMP_OGT;
-    case SemIR::BuiltinFunctionKind::FloatGreaterEq:
-      return llvm::CmpInst::FCMP_OGE;
-    default:
-      CARBON_FATAL() << "Unexpected builtin kind " << builtin_kind;
-  }
-}
-
-// Returns whether the specified instruction has a signed integer type.
-static auto IsSignedInt(FunctionContext& context, SemIR::InstId int_id)
-    -> bool {
-  return context.sem_ir().types().IsSignedInt(
-      context.sem_ir().insts().Get(int_id).type_id());
-}
-
-// Handles a call to a builtin function.
-static auto HandleBuiltinCall(FunctionContext& context, SemIR::InstId inst_id,
-                              SemIR::BuiltinFunctionKind builtin_kind,
-                              llvm::ArrayRef<SemIR::InstId> arg_ids) -> void {
-  // TODO: Consider setting this to true in the performance build mode if the
-  // result type is a signed integer type.
-  constexpr bool SignedOverflowIsUB = false;
-
-  // TODO: Move the instruction names here into InstNamer.
-  switch (builtin_kind) {
-    case SemIR::BuiltinFunctionKind::None:
-      CARBON_FATAL() << "No callee in function call.";
-
-    case SemIR::BuiltinFunctionKind::PrintInt: {
-      llvm::Type* char_type[] = {llvm::PointerType::get(
-          llvm::Type::getInt8Ty(context.llvm_context()), 0)};
-      auto* printf_type = llvm::FunctionType::get(
-          llvm::IntegerType::getInt32Ty(context.llvm_context()),
-          llvm::ArrayRef<llvm::Type*>(char_type, 1), /*isVarArg=*/true);
-      auto callee =
-          context.llvm_module().getOrInsertFunction("printf", printf_type);
-
-      llvm::SmallVector<llvm::Value*, 1> args = {
-          context.builder().CreateGlobalString("%d\n", "printf.int.format")};
-      args.push_back(context.GetValue(arg_ids[0]));
-      context.SetLocal(inst_id,
-                       context.builder().CreateCall(callee, args, "printf"));
-      return;
-    }
-
-    case SemIR::BuiltinFunctionKind::BoolMakeType:
-    case SemIR::BuiltinFunctionKind::FloatMakeType:
-    case SemIR::BuiltinFunctionKind::IntMakeType32:
-    case SemIR::BuiltinFunctionKind::IntMakeTypeSigned:
-    case SemIR::BuiltinFunctionKind::IntMakeTypeUnsigned:
-      context.SetLocal(inst_id, context.GetTypeAsValue());
-      return;
-
-    case SemIR::BuiltinFunctionKind::IntSNegate: {
-      // Lower `-x` as `0 - x`.
-      auto* operand = context.GetValue(arg_ids[0]);
-      context.SetLocal(
-          inst_id,
-          context.builder().CreateSub(
-              llvm::ConstantInt::getNullValue(operand->getType()), operand, "",
-              /*HasNUW=*/false,
-              /*HasNSW=*/SignedOverflowIsUB));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntUNegate: {
-      // Lower `-x` as `0 - x`.
-      auto* operand = context.GetValue(arg_ids[0]);
-      context.SetLocal(
-          inst_id,
-          context.builder().CreateSub(
-              llvm::ConstantInt::getNullValue(operand->getType()), operand));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntComplement: {
-      // Lower `^x` as `-1 ^ x`.
-      auto* operand = context.GetValue(arg_ids[0]);
-      context.SetLocal(
-          inst_id,
-          context.builder().CreateXor(
-              llvm::ConstantInt::getSigned(operand->getType(), -1), operand));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntSAdd: {
-      context.SetLocal(
-          inst_id, context.builder().CreateAdd(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1]), "",
-                                               /*HasNUW=*/false,
-                                               /*HasNSW=*/SignedOverflowIsUB));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntSSub: {
-      context.SetLocal(
-          inst_id, context.builder().CreateSub(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1]), "",
-                                               /*HasNUW=*/false,
-                                               /*HasNSW=*/SignedOverflowIsUB));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntSMul: {
-      context.SetLocal(
-          inst_id, context.builder().CreateMul(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1]), "",
-                                               /*HasNUW=*/false,
-                                               /*HasNSW=*/SignedOverflowIsUB));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntSDiv: {
-      context.SetLocal(
-          inst_id, context.builder().CreateSDiv(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntSMod: {
-      context.SetLocal(
-          inst_id, context.builder().CreateSRem(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntUAdd: {
-      context.SetLocal(
-          inst_id, context.builder().CreateAdd(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntUSub: {
-      context.SetLocal(
-          inst_id, context.builder().CreateSub(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntUMul: {
-      context.SetLocal(
-          inst_id, context.builder().CreateMul(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntUDiv: {
-      context.SetLocal(
-          inst_id, context.builder().CreateUDiv(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntUMod: {
-      context.SetLocal(
-          inst_id, context.builder().CreateURem(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntAnd: {
-      context.SetLocal(
-          inst_id, context.builder().CreateAnd(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntOr: {
-      context.SetLocal(
-          inst_id, context.builder().CreateOr(context.GetValue(arg_ids[0]),
-                                              context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntXor: {
-      context.SetLocal(
-          inst_id, context.builder().CreateXor(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntLeftShift: {
-      context.SetLocal(
-          inst_id, context.builder().CreateShl(context.GetValue(arg_ids[0]),
-                                               context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntRightShift: {
-      context.SetLocal(
-          inst_id,
-          IsSignedInt(context, inst_id)
-              ? context.builder().CreateAShr(context.GetValue(arg_ids[0]),
-                                             context.GetValue(arg_ids[1]))
-              : context.builder().CreateLShr(context.GetValue(arg_ids[0]),
-                                             context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::IntEq:
-    case SemIR::BuiltinFunctionKind::IntNeq:
-    case SemIR::BuiltinFunctionKind::IntLess:
-    case SemIR::BuiltinFunctionKind::IntLessEq:
-    case SemIR::BuiltinFunctionKind::IntGreater:
-    case SemIR::BuiltinFunctionKind::IntGreaterEq: {
-      context.SetLocal(
-          inst_id,
-          context.builder().CreateICmp(
-              GetBuiltinICmpPredicate(builtin_kind,
-                                      IsSignedInt(context, arg_ids[0])),
-              context.GetValue(arg_ids[0]), context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::FloatNegate: {
-      context.SetLocal(
-          inst_id, context.builder().CreateFNeg(context.GetValue(arg_ids[0])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::FloatAdd: {
-      context.SetLocal(
-          inst_id, context.builder().CreateFAdd(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::FloatSub: {
-      context.SetLocal(
-          inst_id, context.builder().CreateFSub(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::FloatMul: {
-      context.SetLocal(
-          inst_id, context.builder().CreateFMul(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::FloatDiv: {
-      context.SetLocal(
-          inst_id, context.builder().CreateFDiv(context.GetValue(arg_ids[0]),
-                                                context.GetValue(arg_ids[1])));
-      return;
-    }
-    case SemIR::BuiltinFunctionKind::FloatEq:
-    case SemIR::BuiltinFunctionKind::FloatNeq:
-    case SemIR::BuiltinFunctionKind::FloatLess:
-    case SemIR::BuiltinFunctionKind::FloatLessEq:
-    case SemIR::BuiltinFunctionKind::FloatGreater:
-    case SemIR::BuiltinFunctionKind::FloatGreaterEq: {
-      context.SetLocal(inst_id, context.builder().CreateFCmp(
-                                    GetBuiltinFCmpPredicate(builtin_kind),
-                                    context.GetValue(arg_ids[0]),
-                                    context.GetValue(arg_ids[1])));
-      return;
-    }
-  }
-
-  CARBON_FATAL() << "Unsupported builtin call.";
-}
-
-auto HandleCall(FunctionContext& context, SemIR::InstId inst_id,
-                SemIR::Call inst) -> void {
-  llvm::ArrayRef<SemIR::InstId> arg_ids =
-      context.sem_ir().inst_blocks().Get(inst.args_id);
-
-  auto callee_function =
-      SemIR::GetCalleeFunction(context.sem_ir(), inst.callee_id);
-  CARBON_CHECK(callee_function.function_id.is_valid());
-
-  if (auto builtin_kind = context.sem_ir()
-                              .functions()
-                              .Get(callee_function.function_id)
-                              .builtin_kind;
-      builtin_kind != SemIR::BuiltinFunctionKind::None) {
-    HandleBuiltinCall(context, inst_id, builtin_kind, arg_ids);
-    return;
-  }
-
-  auto* callee = context.GetFunction(callee_function.function_id);
-
-  std::vector<llvm::Value*> args;
-
-  if (SemIR::GetInitRepr(context.sem_ir(), inst.type_id).has_return_slot()) {
-    args.push_back(context.GetValue(arg_ids.back()));
-    arg_ids = arg_ids.drop_back();
-  }
-
-  for (auto arg_id : arg_ids) {
-    auto arg_type_id = context.sem_ir().insts().Get(arg_id).type_id();
-    if (SemIR::GetValueRepr(context.sem_ir(), arg_type_id).kind !=
-        SemIR::ValueRepr::None) {
-      args.push_back(context.GetValue(arg_id));
-    }
-  }
-
-  context.SetLocal(inst_id, context.builder().CreateCall(callee, args));
-}
-
 auto HandleConverted(FunctionContext& context, SemIR::InstId inst_id,
                      SemIR::Converted inst) -> void {
   context.SetLocal(inst_id, context.GetValue(inst.result_id));

+ 331 - 0
toolchain/lower/handle_call.cpp

@@ -0,0 +1,331 @@
+// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
+// Exceptions. See /LICENSE for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+#include "llvm/IR/Type.h"
+#include "llvm/IR/Value.h"
+#include "toolchain/lower/function_context.h"
+#include "toolchain/sem_ir/builtin_function_kind.h"
+#include "toolchain/sem_ir/ids.h"
+#include "toolchain/sem_ir/typed_insts.h"
+
+namespace Carbon::Lower {
+
+// Get the predicate to use for an `icmp` instruction generated for the
+// specified builtin.
+static auto GetBuiltinICmpPredicate(SemIR::BuiltinFunctionKind builtin_kind,
+                                    bool is_signed)
+    -> llvm::CmpInst::Predicate {
+  switch (builtin_kind) {
+    case SemIR::BuiltinFunctionKind::IntEq:
+      return llvm::CmpInst::ICMP_EQ;
+    case SemIR::BuiltinFunctionKind::IntNeq:
+      return llvm::CmpInst::ICMP_NE;
+    case SemIR::BuiltinFunctionKind::IntLess:
+      return is_signed ? llvm::CmpInst::ICMP_SLT : llvm::CmpInst::ICMP_ULT;
+    case SemIR::BuiltinFunctionKind::IntLessEq:
+      return is_signed ? llvm::CmpInst::ICMP_SLE : llvm::CmpInst::ICMP_ULE;
+    case SemIR::BuiltinFunctionKind::IntGreater:
+      return is_signed ? llvm::CmpInst::ICMP_SGT : llvm::CmpInst::ICMP_UGT;
+    case SemIR::BuiltinFunctionKind::IntGreaterEq:
+      return is_signed ? llvm::CmpInst::ICMP_SGE : llvm::CmpInst::ICMP_UGE;
+    default:
+      CARBON_FATAL() << "Unexpected builtin kind " << builtin_kind;
+  }
+}
+
+// Get the predicate to use for an `fcmp` instruction generated for the
+// specified builtin.
+static auto GetBuiltinFCmpPredicate(SemIR::BuiltinFunctionKind builtin_kind)
+    -> llvm::CmpInst::Predicate {
+  switch (builtin_kind) {
+    case SemIR::BuiltinFunctionKind::FloatEq:
+      return llvm::CmpInst::FCMP_OEQ;
+    case SemIR::BuiltinFunctionKind::FloatNeq:
+      return llvm::CmpInst::FCMP_ONE;
+    case SemIR::BuiltinFunctionKind::FloatLess:
+      return llvm::CmpInst::FCMP_OLT;
+    case SemIR::BuiltinFunctionKind::FloatLessEq:
+      return llvm::CmpInst::FCMP_OLE;
+    case SemIR::BuiltinFunctionKind::FloatGreater:
+      return llvm::CmpInst::FCMP_OGT;
+    case SemIR::BuiltinFunctionKind::FloatGreaterEq:
+      return llvm::CmpInst::FCMP_OGE;
+    default:
+      CARBON_FATAL() << "Unexpected builtin kind " << builtin_kind;
+  }
+}
+
+// Returns whether the specified instruction has a signed integer type.
+static auto IsSignedInt(FunctionContext& context, SemIR::InstId int_id)
+    -> bool {
+  return context.sem_ir().types().IsSignedInt(
+      context.sem_ir().insts().Get(int_id).type_id());
+}
+
+// Handles a call to a builtin function.
+static auto HandleBuiltinCall(FunctionContext& context, SemIR::InstId inst_id,
+                              SemIR::BuiltinFunctionKind builtin_kind,
+                              llvm::ArrayRef<SemIR::InstId> arg_ids) -> void {
+  // TODO: Consider setting this to true in the performance build mode if the
+  // result type is a signed integer type.
+  constexpr bool SignedOverflowIsUB = false;
+
+  // TODO: Move the instruction names here into InstNamer.
+  switch (builtin_kind) {
+    case SemIR::BuiltinFunctionKind::None:
+      CARBON_FATAL() << "No callee in function call.";
+
+    case SemIR::BuiltinFunctionKind::PrintInt: {
+      llvm::Type* char_type[] = {llvm::PointerType::get(
+          llvm::Type::getInt8Ty(context.llvm_context()), 0)};
+      auto* printf_type = llvm::FunctionType::get(
+          llvm::IntegerType::getInt32Ty(context.llvm_context()),
+          llvm::ArrayRef<llvm::Type*>(char_type, 1), /*isVarArg=*/true);
+      auto callee =
+          context.llvm_module().getOrInsertFunction("printf", printf_type);
+
+      llvm::SmallVector<llvm::Value*, 1> args = {
+          context.builder().CreateGlobalString("%d\n", "printf.int.format")};
+      args.push_back(context.GetValue(arg_ids[0]));
+      context.SetLocal(inst_id,
+                       context.builder().CreateCall(callee, args, "printf"));
+      return;
+    }
+
+    case SemIR::BuiltinFunctionKind::BoolMakeType:
+    case SemIR::BuiltinFunctionKind::FloatMakeType:
+    case SemIR::BuiltinFunctionKind::IntMakeType32:
+    case SemIR::BuiltinFunctionKind::IntMakeTypeSigned:
+    case SemIR::BuiltinFunctionKind::IntMakeTypeUnsigned:
+      context.SetLocal(inst_id, context.GetTypeAsValue());
+      return;
+
+    case SemIR::BuiltinFunctionKind::IntSNegate: {
+      // Lower `-x` as `0 - x`.
+      auto* operand = context.GetValue(arg_ids[0]);
+      context.SetLocal(
+          inst_id,
+          context.builder().CreateSub(
+              llvm::ConstantInt::getNullValue(operand->getType()), operand, "",
+              /*HasNUW=*/false,
+              /*HasNSW=*/SignedOverflowIsUB));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntUNegate: {
+      // Lower `-x` as `0 - x`.
+      auto* operand = context.GetValue(arg_ids[0]);
+      context.SetLocal(
+          inst_id,
+          context.builder().CreateSub(
+              llvm::ConstantInt::getNullValue(operand->getType()), operand));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntComplement: {
+      // Lower `^x` as `-1 ^ x`.
+      auto* operand = context.GetValue(arg_ids[0]);
+      context.SetLocal(
+          inst_id,
+          context.builder().CreateXor(
+              llvm::ConstantInt::getSigned(operand->getType(), -1), operand));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntSAdd: {
+      context.SetLocal(
+          inst_id, context.builder().CreateAdd(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1]), "",
+                                               /*HasNUW=*/false,
+                                               /*HasNSW=*/SignedOverflowIsUB));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntSSub: {
+      context.SetLocal(
+          inst_id, context.builder().CreateSub(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1]), "",
+                                               /*HasNUW=*/false,
+                                               /*HasNSW=*/SignedOverflowIsUB));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntSMul: {
+      context.SetLocal(
+          inst_id, context.builder().CreateMul(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1]), "",
+                                               /*HasNUW=*/false,
+                                               /*HasNSW=*/SignedOverflowIsUB));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntSDiv: {
+      context.SetLocal(
+          inst_id, context.builder().CreateSDiv(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntSMod: {
+      context.SetLocal(
+          inst_id, context.builder().CreateSRem(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntUAdd: {
+      context.SetLocal(
+          inst_id, context.builder().CreateAdd(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntUSub: {
+      context.SetLocal(
+          inst_id, context.builder().CreateSub(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntUMul: {
+      context.SetLocal(
+          inst_id, context.builder().CreateMul(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntUDiv: {
+      context.SetLocal(
+          inst_id, context.builder().CreateUDiv(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntUMod: {
+      context.SetLocal(
+          inst_id, context.builder().CreateURem(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntAnd: {
+      context.SetLocal(
+          inst_id, context.builder().CreateAnd(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntOr: {
+      context.SetLocal(
+          inst_id, context.builder().CreateOr(context.GetValue(arg_ids[0]),
+                                              context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntXor: {
+      context.SetLocal(
+          inst_id, context.builder().CreateXor(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntLeftShift: {
+      context.SetLocal(
+          inst_id, context.builder().CreateShl(context.GetValue(arg_ids[0]),
+                                               context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntRightShift: {
+      context.SetLocal(
+          inst_id,
+          IsSignedInt(context, inst_id)
+              ? context.builder().CreateAShr(context.GetValue(arg_ids[0]),
+                                             context.GetValue(arg_ids[1]))
+              : context.builder().CreateLShr(context.GetValue(arg_ids[0]),
+                                             context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::IntEq:
+    case SemIR::BuiltinFunctionKind::IntNeq:
+    case SemIR::BuiltinFunctionKind::IntLess:
+    case SemIR::BuiltinFunctionKind::IntLessEq:
+    case SemIR::BuiltinFunctionKind::IntGreater:
+    case SemIR::BuiltinFunctionKind::IntGreaterEq: {
+      context.SetLocal(
+          inst_id,
+          context.builder().CreateICmp(
+              GetBuiltinICmpPredicate(builtin_kind,
+                                      IsSignedInt(context, arg_ids[0])),
+              context.GetValue(arg_ids[0]), context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::FloatNegate: {
+      context.SetLocal(
+          inst_id, context.builder().CreateFNeg(context.GetValue(arg_ids[0])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::FloatAdd: {
+      context.SetLocal(
+          inst_id, context.builder().CreateFAdd(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::FloatSub: {
+      context.SetLocal(
+          inst_id, context.builder().CreateFSub(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::FloatMul: {
+      context.SetLocal(
+          inst_id, context.builder().CreateFMul(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::FloatDiv: {
+      context.SetLocal(
+          inst_id, context.builder().CreateFDiv(context.GetValue(arg_ids[0]),
+                                                context.GetValue(arg_ids[1])));
+      return;
+    }
+    case SemIR::BuiltinFunctionKind::FloatEq:
+    case SemIR::BuiltinFunctionKind::FloatNeq:
+    case SemIR::BuiltinFunctionKind::FloatLess:
+    case SemIR::BuiltinFunctionKind::FloatLessEq:
+    case SemIR::BuiltinFunctionKind::FloatGreater:
+    case SemIR::BuiltinFunctionKind::FloatGreaterEq: {
+      context.SetLocal(inst_id, context.builder().CreateFCmp(
+                                    GetBuiltinFCmpPredicate(builtin_kind),
+                                    context.GetValue(arg_ids[0]),
+                                    context.GetValue(arg_ids[1])));
+      return;
+    }
+  }
+
+  CARBON_FATAL() << "Unsupported builtin call.";
+}
+
+auto HandleCall(FunctionContext& context, SemIR::InstId inst_id,
+                SemIR::Call inst) -> void {
+  llvm::ArrayRef<SemIR::InstId> arg_ids =
+      context.sem_ir().inst_blocks().Get(inst.args_id);
+
+  auto callee_function =
+      SemIR::GetCalleeFunction(context.sem_ir(), inst.callee_id);
+  CARBON_CHECK(callee_function.function_id.is_valid());
+
+  if (auto builtin_kind = context.sem_ir()
+                              .functions()
+                              .Get(callee_function.function_id)
+                              .builtin_kind;
+      builtin_kind != SemIR::BuiltinFunctionKind::None) {
+    HandleBuiltinCall(context, inst_id, builtin_kind, arg_ids);
+    return;
+  }
+
+  auto* callee = context.GetFunction(callee_function.function_id);
+
+  std::vector<llvm::Value*> args;
+
+  if (SemIR::GetInitRepr(context.sem_ir(), inst.type_id).has_return_slot()) {
+    args.push_back(context.GetValue(arg_ids.back()));
+    arg_ids = arg_ids.drop_back();
+  }
+
+  for (auto arg_id : arg_ids) {
+    auto arg_type_id = context.sem_ir().insts().Get(arg_id).type_id();
+    if (SemIR::GetValueRepr(context.sem_ir(), arg_type_id).kind !=
+        SemIR::ValueRepr::None) {
+      args.push_back(context.GetValue(arg_id));
+    }
+  }
+
+  context.SetLocal(inst_id, context.builder().CreateCall(callee, args));
+}
+
+}  // namespace Carbon::Lower