Selaa lähdekoodia

Sink comment into implementation (#4833)

This comment applies equally to any called passing `check_syntax=false`,
such as for virtual function impls, being tested in #4816
David Blaikie 1 vuosi sitten
vanhempi
sitoutus
b292943648
2 muutettua tiedostoa jossa 6 lisäystä ja 5 poistoa
  1. 6 0
      toolchain/check/function.cpp
  2. 0 5
      toolchain/check/impl.cpp

+ 6 - 0
toolchain/check/function.cpp

@@ -14,6 +14,12 @@ auto CheckFunctionTypeMatches(Context& context,
                               const SemIR::Function& prev_function,
                               SemIR::SpecificId prev_specific_id,
                               bool check_syntax) -> bool {
+  // TODO: When check_syntax is false, the functions should be allowed to have
+  // different signatures as long as we can synthesize a suitable thunk. i.e.,
+  // when there's an implicit conversion from the original parameter types to
+  // the overriding parameter types, and from the overriding return type to the
+  // original return type.
+  // Also, build that thunk.
   if (!CheckRedeclParamsMatch(context, DeclParams(new_function),
                               DeclParams(prev_function), prev_specific_id,
                               check_syntax)) {

+ 0 - 5
toolchain/check/impl.cpp

@@ -129,11 +129,6 @@ static auto CheckAssociatedFunctionImplementation(
               .generic_id,
           self_type_id, witness_inst_id);
 
-  // TODO: The functions should be allowed to have different signatures as long
-  // as we can synthesize a suitable thunk. i.e., when there's an implicit
-  // conversion from the original parameter types to the overriding parameter
-  // types, and from the overriding return type to the original return type.
-  // Also, build that thunk.
   if (!CheckFunctionTypeMatches(
           context, context.functions().Get(impl_function_decl->function_id),
           context.functions().Get(interface_function_type.function_id),