浏览代码

Fix diagnostic messages that don't end in a period. (#3127)

Richard Smith 2 年之前
父节点
当前提交
d74b8f0497

+ 3 - 2
toolchain/semantics/semantics_context.cpp

@@ -44,7 +44,8 @@ SemanticsContext::SemanticsContext(const TokenizedBuffer& tokens,
 
 auto SemanticsContext::TODO(ParseTree::Node parse_node, std::string label)
     -> bool {
-  CARBON_DIAGNOSTIC(SemanticsTodo, Error, "Semantics TODO: {0}", std::string);
+  CARBON_DIAGNOSTIC(SemanticsTodo, Error, "Semantics TODO: `{0}`.",
+                    std::string);
   emitter_->Emit(parse_node, SemanticsTodo, std::move(label));
   return false;
 }
@@ -91,7 +92,7 @@ auto SemanticsContext::DiagnoseDuplicateName(ParseTree::Node parse_node,
 
 auto SemanticsContext::DiagnoseNameNotFound(ParseTree::Node parse_node,
                                             SemanticsStringId name_id) -> void {
-  CARBON_DIAGNOSTIC(NameNotFound, Error, "Name `{0}` not found",
+  CARBON_DIAGNOSTIC(NameNotFound, Error, "Name `{0}` not found.",
                     llvm::StringRef);
   emitter_->Emit(parse_node, NameNotFound, semantics_ir_->GetString(name_id));
 }

+ 1 - 1
toolchain/semantics/testdata/array/fail_undefined_bound.carbon

@@ -4,7 +4,7 @@
 //
 // AUTOUPDATE
 
-// CHECK:STDERR: fail_undefined_bound.carbon:[[@LINE+3]]:14: Semantics TODO: HandleArrayExpressionWithoutBounds
+// CHECK:STDERR: fail_undefined_bound.carbon:[[@LINE+3]]:14: Semantics TODO: `HandleArrayExpressionWithoutBounds`.
 // CHECK:STDERR: var a: [i32; ];
 // CHECK:STDERR:              ^
 var a: [i32; ];

+ 1 - 1
toolchain/semantics/testdata/basics/fail_name_lookup.carbon

@@ -5,7 +5,7 @@
 // AUTOUPDATE
 
 fn Main() {
-  // CHECK:STDERR: fail_name_lookup.carbon:[[@LINE+3]]:3: Name `x` not found
+  // CHECK:STDERR: fail_name_lookup.carbon:[[@LINE+3]]:3: Name `x` not found.
   // CHECK:STDERR:   x;
   // CHECK:STDERR:   ^
   x;

+ 1 - 1
toolchain/semantics/testdata/if/fail_scope.carbon

@@ -9,7 +9,7 @@ fn VarScope(b: bool) -> i32 {
     var n: i32 = 2;
     return n;
   }
-  // CHECK:STDERR: fail_scope.carbon:[[@LINE+3]]:10: Name `n` not found
+  // CHECK:STDERR: fail_scope.carbon:[[@LINE+3]]:10: Name `n` not found.
   // CHECK:STDERR:   return n;
   // CHECK:STDERR:          ^
   return n;

+ 1 - 1
toolchain/semantics/testdata/index/fail_name_not_found.carbon

@@ -5,7 +5,7 @@
 // AUTOUPDATE
 
 fn Main() {
-  // CHECK:STDERR: fail_name_not_found.carbon:[[@LINE+3]]:16: Name `a` not found
+  // CHECK:STDERR: fail_name_not_found.carbon:[[@LINE+3]]:16: Name `a` not found.
   // CHECK:STDERR:   var b: i32 = a[0];
   // CHECK:STDERR:                ^
   var b: i32 = a[0];

+ 1 - 1
toolchain/semantics/testdata/index/fail_negative_indexing.carbon

@@ -5,7 +5,7 @@
 // AUTOUPDATE
 
 var a: (i32, i32) = (12, 6);
-// CHECK:STDERR: fail_negative_indexing.carbon:[[@LINE+3]]:16: Semantics TODO: Handle -
+// CHECK:STDERR: fail_negative_indexing.carbon:[[@LINE+3]]:16: Semantics TODO: `Handle -`.
 // CHECK:STDERR: var b: i32 = a[-10];
 // CHECK:STDERR:                ^
 var b: i32 = a[-10];

+ 1 - 1
toolchain/semantics/testdata/namespace/fail_unresolved_scope.carbon

@@ -4,7 +4,7 @@
 //
 // AUTOUPDATE
 
-// CHECK:STDERR: fail_unresolved_scope.carbon:[[@LINE+3]]:4: Name `Foo` not found
+// CHECK:STDERR: fail_unresolved_scope.carbon:[[@LINE+3]]:4: Name `Foo` not found.
 // CHECK:STDERR: fn Foo.Baz() {
 // CHECK:STDERR:    ^
 fn Foo.Baz() {

+ 1 - 1
toolchain/semantics/testdata/struct/fail_access_into_invalid.carbon

@@ -5,7 +5,7 @@
 // AUTOUPDATE
 
 
-// CHECK:STDERR: fail_access_into_invalid.carbon:[[@LINE+3]]:10: Name `a` not found
+// CHECK:STDERR: fail_access_into_invalid.carbon:[[@LINE+3]]:10: Name `a` not found.
 // CHECK:STDERR: fn F() { a.b; }
 // CHECK:STDERR:          ^
 fn F() { a.b; }

+ 1 - 1
toolchain/semantics/testdata/var/fail_init_with_self.carbon

@@ -5,7 +5,7 @@
 // AUTOUPDATE
 
 fn Main() {
-  // CHECK:STDERR: fail_init_with_self.carbon:[[@LINE+3]]:16: Name `x` not found
+  // CHECK:STDERR: fail_init_with_self.carbon:[[@LINE+3]]:16: Name `x` not found.
   // CHECK:STDERR:   var x: i32 = x;
   // CHECK:STDERR:                ^
   var x: i32 = x;

+ 1 - 1
toolchain/semantics/testdata/var/fail_lookup_outside_scope.carbon

@@ -8,7 +8,7 @@ fn Main() {
   var x: i32;
 }
 
-// CHECK:STDERR: fail_lookup_outside_scope.carbon:[[@LINE+3]]:14: Name `x` not found
+// CHECK:STDERR: fail_lookup_outside_scope.carbon:[[@LINE+3]]:14: Name `x` not found.
 // CHECK:STDERR: var y: i32 = x;
 // CHECK:STDERR:              ^
 var y: i32 = x;