impl_lookup.cpp 38 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934
  1. // Part of the Carbon Language project, under the Apache License v2.0 with LLVM
  2. // Exceptions. See /LICENSE for license information.
  3. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
  4. #include "toolchain/check/impl_lookup.h"
  5. #include <algorithm>
  6. #include <functional>
  7. #include <utility>
  8. #include <variant>
  9. #include "toolchain/base/kind_switch.h"
  10. #include "toolchain/check/deduce.h"
  11. #include "toolchain/check/diagnostic_helpers.h"
  12. #include "toolchain/check/eval.h"
  13. #include "toolchain/check/facet_type.h"
  14. #include "toolchain/check/generic.h"
  15. #include "toolchain/check/impl.h"
  16. #include "toolchain/check/import_ref.h"
  17. #include "toolchain/check/inst.h"
  18. #include "toolchain/check/subst.h"
  19. #include "toolchain/check/type.h"
  20. #include "toolchain/check/type_completion.h"
  21. #include "toolchain/check/type_structure.h"
  22. #include "toolchain/sem_ir/facet_type_info.h"
  23. #include "toolchain/sem_ir/ids.h"
  24. #include "toolchain/sem_ir/impl.h"
  25. #include "toolchain/sem_ir/inst.h"
  26. #include "toolchain/sem_ir/typed_insts.h"
  27. namespace Carbon::Check {
  28. // Returns IRs which are allowed to define an `impl` involving the arguments.
  29. // This is limited by the orphan rule.
  30. static auto FindAssociatedImportIRs(
  31. Context& context, SemIR::ConstantId query_self_const_id,
  32. SemIR::SpecificInterface query_specific_interface)
  33. -> llvm::SmallVector<SemIR::ImportIRId> {
  34. llvm::SmallVector<SemIR::ImportIRId> result;
  35. // Add an entity to our result.
  36. auto add_entity = [&](const SemIR::EntityWithParamsBase& entity) {
  37. // We will look for impls in the import IR associated with the first owning
  38. // declaration.
  39. auto decl_id = entity.first_owning_decl_id;
  40. if (!decl_id.has_value()) {
  41. return;
  42. }
  43. if (auto ir_id = GetCanonicalImportIRInst(context, decl_id).ir_id();
  44. ir_id.has_value()) {
  45. result.push_back(ir_id);
  46. }
  47. };
  48. llvm::SmallVector<SemIR::InstId> worklist;
  49. // Push the contents of an instruction block onto our worklist.
  50. auto push_block = [&](SemIR::InstBlockId block_id) {
  51. if (block_id.has_value()) {
  52. llvm::append_range(worklist, context.inst_blocks().Get(block_id));
  53. }
  54. };
  55. // Add the arguments of a specific to the worklist.
  56. auto push_args = [&](SemIR::SpecificId specific_id) {
  57. if (specific_id.has_value()) {
  58. push_block(context.specifics().Get(specific_id).args_id);
  59. }
  60. };
  61. worklist.push_back(context.constant_values().GetInstId(query_self_const_id));
  62. add_entity(context.interfaces().Get(query_specific_interface.interface_id));
  63. push_args(query_specific_interface.specific_id);
  64. while (!worklist.empty()) {
  65. auto inst_id = worklist.pop_back_val();
  66. // Visit the operands of the constant.
  67. auto inst = context.insts().Get(inst_id);
  68. for (auto arg : {inst.arg0_and_kind(), inst.arg1_and_kind()}) {
  69. CARBON_KIND_SWITCH(arg) {
  70. case CARBON_KIND(SemIR::InstId inst_id): {
  71. if (inst_id.has_value()) {
  72. worklist.push_back(inst_id);
  73. }
  74. break;
  75. }
  76. case CARBON_KIND(SemIR::TypeInstId inst_id): {
  77. if (inst_id.has_value()) {
  78. worklist.push_back(inst_id);
  79. }
  80. break;
  81. }
  82. case CARBON_KIND(SemIR::InstBlockId inst_block_id): {
  83. push_block(inst_block_id);
  84. break;
  85. }
  86. case CARBON_KIND(SemIR::ClassId class_id): {
  87. add_entity(context.classes().Get(class_id));
  88. break;
  89. }
  90. case CARBON_KIND(SemIR::InterfaceId interface_id): {
  91. add_entity(context.interfaces().Get(interface_id));
  92. break;
  93. }
  94. case CARBON_KIND(SemIR::FacetTypeId facet_type_id): {
  95. const auto& facet_type_info =
  96. context.facet_types().Get(facet_type_id);
  97. for (const auto& impl : facet_type_info.extend_constraints) {
  98. add_entity(context.interfaces().Get(impl.interface_id));
  99. push_args(impl.specific_id);
  100. }
  101. for (const auto& impl : facet_type_info.self_impls_constraints) {
  102. add_entity(context.interfaces().Get(impl.interface_id));
  103. push_args(impl.specific_id);
  104. }
  105. break;
  106. }
  107. case CARBON_KIND(SemIR::FunctionId function_id): {
  108. add_entity(context.functions().Get(function_id));
  109. break;
  110. }
  111. case CARBON_KIND(SemIR::SpecificId specific_id): {
  112. push_args(specific_id);
  113. break;
  114. }
  115. default: {
  116. break;
  117. }
  118. }
  119. }
  120. }
  121. // Deduplicate.
  122. llvm::sort(result, [](SemIR::ImportIRId a, SemIR::ImportIRId b) {
  123. return a.index < b.index;
  124. });
  125. result.erase(llvm::unique(result), result.end());
  126. return result;
  127. }
  128. // Returns true if a cycle was found and diagnosed.
  129. static auto FindAndDiagnoseImplLookupCycle(
  130. Context& context,
  131. const llvm::SmallVector<Context::ImplLookupStackEntry>& stack,
  132. SemIR::LocId loc_id, SemIR::ConstantId query_self_const_id,
  133. SemIR::ConstantId query_facet_type_const_id) -> bool {
  134. // Deduction of the interface parameters can do further impl lookups, and we
  135. // need to ensure we terminate.
  136. //
  137. // https://docs.carbon-lang.dev/docs/design/generics/details.html#acyclic-rule
  138. // - We look for violations of the acyclic rule by seeing if a previous lookup
  139. // had all the same type inputs.
  140. // - The `query_facet_type_const_id` encodes the entire facet type being
  141. // looked up, including any specific parameters for a generic interface.
  142. //
  143. // TODO: Implement the termination rule, which requires looking at the
  144. // complexity of the types on the top of (or throughout?) the stack:
  145. // https://docs.carbon-lang.dev/docs/design/generics/details.html#termination-rule
  146. for (auto [i, entry] : llvm::enumerate(stack)) {
  147. if (entry.query_self_const_id == query_self_const_id &&
  148. entry.query_facet_type_const_id == query_facet_type_const_id) {
  149. auto facet_type_type_id =
  150. context.types().GetTypeIdForTypeConstantId(query_facet_type_const_id);
  151. CARBON_DIAGNOSTIC(ImplLookupCycle, Error,
  152. "cycle found in search for impl of {0} for type {1}",
  153. SemIR::TypeId, SemIR::TypeId);
  154. auto builder = context.emitter().Build(
  155. loc_id, ImplLookupCycle, facet_type_type_id,
  156. context.types().GetTypeIdForTypeConstantId(query_self_const_id));
  157. for (const auto& active_entry : llvm::drop_begin(stack, i)) {
  158. if (active_entry.impl_loc.has_value()) {
  159. CARBON_DIAGNOSTIC(ImplLookupCycleNote, Note,
  160. "determining if this impl clause matches", );
  161. builder.Note(active_entry.impl_loc, ImplLookupCycleNote);
  162. }
  163. }
  164. builder.Emit();
  165. return true;
  166. }
  167. }
  168. return false;
  169. }
  170. // Gets the set of `SpecificInterface`s that are required by a facet type
  171. // (as a constant value).
  172. static auto GetInterfacesFromConstantId(
  173. Context& context, SemIR::ConstantId query_facet_type_const_id,
  174. bool& has_other_requirements)
  175. -> llvm::SmallVector<SemIR::SpecificInterface> {
  176. auto facet_type_inst_id =
  177. context.constant_values().GetInstId(query_facet_type_const_id);
  178. auto facet_type_inst =
  179. context.insts().GetAs<SemIR::FacetType>(facet_type_inst_id);
  180. const auto& facet_type_info =
  181. context.facet_types().Get(facet_type_inst.facet_type_id);
  182. has_other_requirements = facet_type_info.other_requirements;
  183. auto identified_id = RequireIdentifiedFacetType(context, facet_type_inst);
  184. auto interfaces_array_ref =
  185. context.identified_facet_types().Get(identified_id).required_interfaces();
  186. // Returns a copy to avoid use-after-free when the identified_facet_types
  187. // store resizes.
  188. return {interfaces_array_ref.begin(), interfaces_array_ref.end()};
  189. }
  190. static auto GetWitnessIdForImpl(Context& context, SemIR::LocId loc_id,
  191. bool query_is_concrete,
  192. SemIR::ConstantId query_self_const_id,
  193. const SemIR::SpecificInterface& interface,
  194. SemIR::ImplId impl_id) -> EvalImplLookupResult {
  195. const SemIR::Impl& impl = context.impls().Get(impl_id);
  196. // The impl may have generic arguments, in which case we need to deduce them
  197. // to find what they are given the specific type and interface query. We use
  198. // that specific to map values in the impl to the deduced values.
  199. auto specific_id = SemIR::SpecificId::None;
  200. if (impl.generic_id.has_value()) {
  201. specific_id = DeduceImplArguments(
  202. context, loc_id, impl, query_self_const_id, interface.specific_id);
  203. if (!specific_id.has_value()) {
  204. return EvalImplLookupResult::MakeNone();
  205. }
  206. }
  207. // The self type of the impl must match the type in the query, or this is an
  208. // `impl T as ...` for some other type `T` and should not be considered.
  209. auto deduced_self_const_id = SemIR::GetConstantValueInSpecific(
  210. context.sem_ir(), specific_id, impl.self_id);
  211. // In a generic `impl forall` the self type can be a FacetAccessType, which
  212. // will not be the same constant value as a query facet value. We move through
  213. // to the facet value here, and if the query was a FacetAccessType we did the
  214. // same there so they still match.
  215. deduced_self_const_id =
  216. GetCanonicalizedFacetOrTypeValue(context, deduced_self_const_id);
  217. if (query_self_const_id != deduced_self_const_id) {
  218. return EvalImplLookupResult::MakeNone();
  219. }
  220. // The impl's constraint is a facet type which it is implementing for the self
  221. // type: the `I` in `impl ... as I`. The deduction step may be unable to be
  222. // fully applied to the types in the constraint and result in an error here,
  223. // in which case it does not match the query.
  224. auto deduced_constraint_id =
  225. context.constant_values().GetInstId(SemIR::GetConstantValueInSpecific(
  226. context.sem_ir(), specific_id, impl.constraint_id));
  227. if (deduced_constraint_id == SemIR::ErrorInst::InstId) {
  228. return EvalImplLookupResult::MakeNone();
  229. }
  230. auto deduced_constraint_facet_type_id =
  231. context.insts()
  232. .GetAs<SemIR::FacetType>(deduced_constraint_id)
  233. .facet_type_id;
  234. const auto& deduced_constraint_facet_type_info =
  235. context.facet_types().Get(deduced_constraint_facet_type_id);
  236. CARBON_CHECK(deduced_constraint_facet_type_info.extend_constraints.size() ==
  237. 1);
  238. if (deduced_constraint_facet_type_info.other_requirements) {
  239. // TODO: Remove this when other requirements goes away.
  240. return EvalImplLookupResult::MakeNone();
  241. }
  242. // The specifics in the queried interface must match the deduced specifics in
  243. // the impl's constraint facet type.
  244. auto impl_interface_specific_id =
  245. deduced_constraint_facet_type_info.extend_constraints[0].specific_id;
  246. auto query_interface_specific_id = interface.specific_id;
  247. if (impl_interface_specific_id != query_interface_specific_id) {
  248. return EvalImplLookupResult::MakeNone();
  249. }
  250. LoadImportRef(context, impl.witness_id);
  251. if (specific_id.has_value()) {
  252. // We need a definition of the specific `impl` so we can access its
  253. // witness.
  254. ResolveSpecificDefinition(context, loc_id, specific_id);
  255. }
  256. if (query_is_concrete || impl.is_final) {
  257. // TODO: These final results should be cached somehow. Positive (non-None)
  258. // results could be cached globally, as they can not change. But
  259. // negative results can change after a final impl is written, so
  260. // they can only be cached in a limited way, or the cache needs to
  261. // be invalidated by writing a final impl that would match.
  262. return EvalImplLookupResult::MakeFinal(
  263. context.constant_values().GetInstId(SemIR::GetConstantValueInSpecific(
  264. context.sem_ir(), specific_id, impl.witness_id)));
  265. } else {
  266. return EvalImplLookupResult::MakeNonFinal();
  267. }
  268. }
  269. // Unwraps a FacetAccessType to move from a value of type `TypeType` to a facet
  270. // value of type `FacetType` if possible.
  271. //
  272. // Generally `GetCanonicalizedFacetOrTypeValue()` is what you want to call
  273. // instead, as this only does part of that operation, potentially returning a
  274. // non-canonical facet value.
  275. static auto UnwrapFacetAccessType(Context& context, SemIR::InstId inst_id)
  276. -> SemIR::InstId {
  277. if (auto access = context.insts().TryGetAs<SemIR::FacetAccessType>(inst_id)) {
  278. return access->facet_value_inst_id;
  279. }
  280. return inst_id;
  281. }
  282. // Finds a lookup result from `query_self_inst_id` if it is a facet value that
  283. // names the query interface in its facet type. Note that `query_self_inst_id`
  284. // is allowed to be a non-canonical facet value in order to find a concrete
  285. // witness, so it's not referenced as a constant value.
  286. static auto LookupImplWitnessInSelfFacetValue(
  287. Context& context, SemIR::InstId query_self_inst_id,
  288. SemIR::SpecificInterface query_specific_interface) -> EvalImplLookupResult {
  289. // Unwrap FacetAccessType without getting the canonical facet value from the
  290. // self value, as we want to preserve the non-canonical `FacetValue`
  291. // instruction which can contain the concrete witness.
  292. query_self_inst_id = UnwrapFacetAccessType(context, query_self_inst_id);
  293. auto facet_type = context.types().TryGetAs<SemIR::FacetType>(
  294. context.insts().Get(query_self_inst_id).type_id());
  295. if (!facet_type) {
  296. return EvalImplLookupResult::MakeNone();
  297. }
  298. // The position of the interface in `required_interfaces()` is also the
  299. // position of the witness for that interface in `FacetValue`.
  300. auto identified_id = RequireIdentifiedFacetType(context, *facet_type);
  301. auto facet_type_required_interfaces =
  302. llvm::enumerate(context.identified_facet_types()
  303. .Get(identified_id)
  304. .required_interfaces());
  305. auto it = llvm::find_if(facet_type_required_interfaces, [=](auto e) {
  306. return e.value() == query_specific_interface;
  307. });
  308. if (it == facet_type_required_interfaces.end()) {
  309. return EvalImplLookupResult::MakeNone();
  310. }
  311. auto index = (*it).index();
  312. if (auto facet_value =
  313. context.insts().TryGetAs<SemIR::FacetValue>(query_self_inst_id)) {
  314. auto witness_id =
  315. context.inst_blocks().Get(facet_value->witnesses_block_id)[index];
  316. if (context.insts().Is<SemIR::ImplWitness>(witness_id)) {
  317. return EvalImplLookupResult::MakeFinal(witness_id);
  318. }
  319. }
  320. return EvalImplLookupResult::MakeNonFinal();
  321. }
  322. // Substitutes witnesess in place of `LookupImplWitness` queries into `.Self`,
  323. // when the witness is for the same interface as the one `.Self` is referring
  324. // to.
  325. //
  326. // This allows access to the `FacetType` and its constraints from the witness,
  327. // and allows `ImplWitnessAccess` instructions to be immediately resolved to a
  328. // more specific value when possible.
  329. class SubstWitnessesCallbacks : public SubstInstCallbacks {
  330. public:
  331. // `context` must not be null.
  332. explicit SubstWitnessesCallbacks(
  333. Context* context, SemIR::LocId loc_id,
  334. llvm::ArrayRef<SemIR::SpecificInterface> interfaces,
  335. llvm::ArrayRef<SemIR::InstId> witness_inst_ids)
  336. : SubstInstCallbacks(context),
  337. loc_id_(loc_id),
  338. interfaces_(interfaces),
  339. witness_inst_ids_(witness_inst_ids) {}
  340. auto Subst(SemIR::InstId& inst_id) -> SubstResult override {
  341. // `FacetType` can be concrete even when it has rewrite constraints that
  342. // have a symbolic dependency on `.Self`. See use of
  343. // `GetConstantValueIgnoringPeriodSelf` in eval. So in order to recurse into
  344. // `FacetType` we must check for it before the `is_concrete` early return.
  345. if (context().insts().Is<SemIR::FacetType>(inst_id)) {
  346. ++facet_type_depth_;
  347. return SubstOperands;
  348. }
  349. if (context().constant_values().Get(inst_id).is_concrete()) {
  350. return FullySubstituted;
  351. }
  352. auto access = context().insts().TryGetAs<SemIR::ImplWitnessAccess>(inst_id);
  353. if (!access) {
  354. return SubstOperands;
  355. }
  356. auto lookup =
  357. context().insts().GetAs<SemIR::LookupImplWitness>(access->witness_id);
  358. auto bind_name = context().insts().TryGetAs<SemIR::BindSymbolicName>(
  359. lookup.query_self_inst_id);
  360. if (!bind_name) {
  361. return SubstOperands;
  362. }
  363. const auto& self_entity_name =
  364. context().entity_names().Get(bind_name->entity_name_id);
  365. if (self_entity_name.name_id != SemIR::NameId::PeriodSelf) {
  366. return SubstOperands;
  367. }
  368. // TODO: Once we are numbering `EntityName`, (see the third model in
  369. // https://docs.google.com/document/d/1Yt-i5AmF76LSvD4TrWRIAE_92kii6j5yFiW-S7ahzlg/edit?tab=t.0#heading=h.7urbxcq23olv)
  370. // then verify that the index here is equal to the `facet_type_depth_`,
  371. // which would mean that it is a reference to the top-level `Self`, which is
  372. // being replaced with the impl lookup query self facet value (and then we
  373. // use the witness derived from it).
  374. //
  375. // For now, we only substitute if depth == 0, which is incorrect inside
  376. // nested facet types, as it can miss references in specifics up to the top
  377. // level facet value.
  378. if (facet_type_depth_ > 0) {
  379. return SubstOperands;
  380. }
  381. auto witness_id =
  382. FindWitnessForInterface(lookup.query_specific_interface_id);
  383. if (!witness_id.has_value()) {
  384. return SubstOperands;
  385. }
  386. inst_id = RebuildNewInst(
  387. context().insts().GetLocIdForDesugaring(loc_id_),
  388. SemIR::ImplWitnessAccess{.type_id = GetSingletonType(
  389. context(), SemIR::WitnessType::TypeInstId),
  390. .witness_id = witness_id,
  391. .index = access->index});
  392. // Once we replace a witness, we either have a concrete value or some
  393. // reference to an associated constant that came from the witness's facet
  394. // type. We don't want to substitute into the witness's facet type, so we
  395. // don't recurse on whatever came from the witness.
  396. return FullySubstituted;
  397. }
  398. auto Rebuild(SemIR::InstId orig_inst_id, SemIR::Inst new_inst)
  399. -> SemIR::InstId override {
  400. if (context().insts().Is<SemIR::FacetType>(orig_inst_id)) {
  401. --facet_type_depth_;
  402. }
  403. return RebuildNewInst(loc_id_, new_inst);
  404. }
  405. auto ReuseUnchanged(SemIR::InstId orig_inst_id) -> SemIR::InstId override {
  406. if (context().insts().Is<SemIR::FacetType>(orig_inst_id)) {
  407. --facet_type_depth_;
  408. }
  409. return orig_inst_id;
  410. }
  411. private:
  412. auto FindWitnessForInterface(SemIR::SpecificInterfaceId specific_interface_id)
  413. -> SemIR::InstId {
  414. auto lookup_query_interface =
  415. context().specific_interfaces().Get(specific_interface_id);
  416. for (auto [interface, witness_inst_id] :
  417. llvm::zip(interfaces_, witness_inst_ids_)) {
  418. // If the `LookupImplWitness` for `.Self` is not looking for the same
  419. // interface as we have a witness for, this is not the right witness to
  420. // use to replace the lookup for `.Self`.
  421. if (interface.interface_id == lookup_query_interface.interface_id) {
  422. return witness_inst_id;
  423. }
  424. }
  425. return SemIR::InstId::None;
  426. }
  427. SemIR::LocId loc_id_;
  428. llvm::ArrayRef<SemIR::SpecificInterface> interfaces_;
  429. llvm::ArrayRef<SemIR::InstId> witness_inst_ids_;
  430. int facet_type_depth_ = 0;
  431. };
  432. static auto VerifyQueryFacetTypeConstraints(
  433. Context& context, SemIR::LocId loc_id,
  434. SemIR::InstId query_facet_type_inst_id,
  435. llvm::ArrayRef<SemIR::SpecificInterface> interfaces,
  436. llvm::ArrayRef<SemIR::InstId> witness_inst_ids) -> bool {
  437. CARBON_CHECK(context.insts().Is<SemIR::FacetType>(query_facet_type_inst_id));
  438. const auto& facet_type_info = context.facet_types().Get(
  439. context.insts()
  440. .GetAs<SemIR::FacetType>(query_facet_type_inst_id)
  441. .facet_type_id);
  442. if (!facet_type_info.rewrite_constraints.empty()) {
  443. auto callbacks =
  444. SubstWitnessesCallbacks(&context, loc_id, interfaces, witness_inst_ids);
  445. for (const auto& rewrite : facet_type_info.rewrite_constraints) {
  446. auto lhs_id = SubstInst(context, rewrite.lhs_id, callbacks);
  447. auto rhs_id = SubstInst(context, rewrite.rhs_id, callbacks);
  448. if (lhs_id != rhs_id) {
  449. // TODO: Provide a diagnostic note and location for which rewrite
  450. // constraint was not satisfied, if a diagnostic is going to be
  451. // displayed for the LookupImplWitessFailure. This will require plumbing
  452. // through a callback that lets us add a Note to another diagnostic.
  453. return false;
  454. }
  455. }
  456. }
  457. // TODO: Validate that the witnesses satisfy the other requirements in the
  458. // `facet_type_info`.
  459. return true;
  460. }
  461. // Begin a search for an impl declaration matching the query. We do this by
  462. // creating an LookupImplWitness instruction and evaluating. If it's able to
  463. // find a final concrete impl, then it will evaluate to that `ImplWitness` but
  464. // if not, it will evaluate to itself as a symbolic witness to be further
  465. // evaluated with a more specific query when building a specific for the generic
  466. // context the query came from.
  467. static auto GetOrAddLookupImplWitness(Context& context, SemIR::LocId loc_id,
  468. SemIR::ConstantId query_self_const_id,
  469. SemIR::SpecificInterface interface)
  470. -> SemIR::InstId {
  471. auto witness_const_id = EvalOrAddInst(
  472. context, context.insts().GetLocIdForDesugaring(loc_id),
  473. SemIR::LookupImplWitness{
  474. .type_id = GetSingletonType(context, SemIR::WitnessType::TypeInstId),
  475. .query_self_inst_id =
  476. context.constant_values().GetInstId(query_self_const_id),
  477. .query_specific_interface_id =
  478. context.specific_interfaces().Add(interface),
  479. });
  480. // We use a NotConstant result from eval to communicate back an impl
  481. // lookup failure. See `EvalConstantInst()` for `LookupImplWitness`.
  482. if (!witness_const_id.is_constant()) {
  483. return SemIR::InstId::None;
  484. }
  485. return context.constant_values().GetInstId(witness_const_id);
  486. }
  487. auto LookupImplWitness(Context& context, SemIR::LocId loc_id,
  488. SemIR::ConstantId query_self_const_id,
  489. SemIR::ConstantId query_facet_type_const_id)
  490. -> SemIR::InstBlockIdOrError {
  491. if (query_self_const_id == SemIR::ErrorInst::ConstantId ||
  492. query_facet_type_const_id == SemIR::ErrorInst::ConstantId) {
  493. return SemIR::InstBlockIdOrError::MakeError();
  494. }
  495. {
  496. // The query self value is a type value or a facet value.
  497. auto query_self_type_id =
  498. context.insts()
  499. .Get(context.constant_values().GetInstId(query_self_const_id))
  500. .type_id();
  501. CARBON_CHECK(context.types().Is<SemIR::TypeType>(query_self_type_id) ||
  502. context.types().Is<SemIR::FacetType>(query_self_type_id));
  503. // The query facet type value is indeed a facet type.
  504. CARBON_CHECK(context.insts().Is<SemIR::FacetType>(
  505. context.constant_values().GetInstId(query_facet_type_const_id)));
  506. }
  507. bool has_other_requirements = false;
  508. auto interfaces = GetInterfacesFromConstantId(
  509. context, query_facet_type_const_id, has_other_requirements);
  510. if (has_other_requirements) {
  511. // TODO: Remove this when other requirements go away.
  512. return SemIR::InstBlockId::None;
  513. }
  514. if (interfaces.empty()) {
  515. return SemIR::InstBlockId::Empty;
  516. }
  517. if (FindAndDiagnoseImplLookupCycle(context, context.impl_lookup_stack(),
  518. loc_id, query_self_const_id,
  519. query_facet_type_const_id)) {
  520. return SemIR::InstBlockIdOrError::MakeError();
  521. }
  522. auto& stack = context.impl_lookup_stack();
  523. stack.push_back({
  524. .query_self_const_id = query_self_const_id,
  525. .query_facet_type_const_id = query_facet_type_const_id,
  526. });
  527. // We need to find a witness for each interface in `interfaces`. Every
  528. // consumer of a facet type needs to agree on the order of interfaces used for
  529. // its witnesses.
  530. llvm::SmallVector<SemIR::InstId> result_witness_ids;
  531. for (const auto& interface : interfaces) {
  532. // TODO: Since both `interfaces` and `query_self_const_id` are sorted lists,
  533. // do an O(N+M) merge instead of O(N*M) nested loops.
  534. auto result_witness_id = GetOrAddLookupImplWitness(
  535. context, loc_id, query_self_const_id, interface);
  536. if (result_witness_id.has_value()) {
  537. result_witness_ids.push_back(result_witness_id);
  538. } else {
  539. // At least one queried interface in the facet type has no witness for the
  540. // given type, we can stop looking for more.
  541. break;
  542. }
  543. }
  544. stack.pop_back();
  545. // All interfaces in the query facet type must have been found to be available
  546. // through some impl, or directly on the value's facet type if
  547. // `query_self_const_id` is a facet value.
  548. if (result_witness_ids.size() != interfaces.size()) {
  549. return SemIR::InstBlockId::None;
  550. }
  551. // Verify rewrite constraints in the query constraint are satisfied after
  552. // applying the rewrites from the found witnesses.
  553. if (!VerifyQueryFacetTypeConstraints(
  554. context, loc_id,
  555. context.constant_values().GetInstId(query_facet_type_const_id),
  556. interfaces, result_witness_ids)) {
  557. return SemIR::InstBlockId::None;
  558. }
  559. return context.inst_blocks().AddCanonical(result_witness_ids);
  560. }
  561. // Returns whether the query is concrete, it is false if the self type or
  562. // interface specifics have a symbolic dependency.
  563. static auto QueryIsConcrete(Context& context, SemIR::ConstantId self_const_id,
  564. const SemIR::SpecificInterface& specific_interface)
  565. -> bool {
  566. if (!self_const_id.is_concrete()) {
  567. return false;
  568. }
  569. if (!specific_interface.specific_id.has_value()) {
  570. return true;
  571. }
  572. auto args_id =
  573. context.specifics().Get(specific_interface.specific_id).args_id;
  574. for (auto inst_id : context.inst_blocks().Get(args_id)) {
  575. if (!context.constant_values().Get(inst_id).is_concrete()) {
  576. return false;
  577. }
  578. }
  579. return true;
  580. }
  581. namespace {
  582. // A class to filter imported impls based on whether they could possibly match a
  583. // query, prior to importing them. For now we only consider impls that are for
  584. // an interface that's being queried.
  585. //
  586. // TODO: There's a lot more we could do to filter out impls that can't possibly
  587. // match.
  588. class ImportImplFilter {
  589. public:
  590. explicit ImportImplFilter(Context& context, SemIR::ImportIRId import_ir_id,
  591. SemIR::SpecificInterface interface)
  592. : context_(&context),
  593. interface_id_(interface.interface_id),
  594. import_ir_id_(import_ir_id),
  595. import_ir_(context_->import_irs().Get(import_ir_id).sem_ir),
  596. cached_import_interface_id_(SemIR::InterfaceId::None) {}
  597. // Returns whether the given impl is potentially relevant for the current
  598. // query.
  599. auto IsRelevantImpl(SemIR::ImplId import_impl_id) -> bool {
  600. auto impl_interface_id =
  601. import_ir_->impls().Get(import_impl_id).interface.interface_id;
  602. if (!impl_interface_id.has_value()) {
  603. // This indicates that an error occurred when type-checking the impl.
  604. // TODO: Use an explicit error value for this rather than None.
  605. return false;
  606. }
  607. return IsRelevantInterface(impl_interface_id);
  608. }
  609. private:
  610. // Returns whether an impl for the given interface might be relevant to the
  611. // current query.
  612. auto IsRelevantInterface(SemIR::InterfaceId import_interface_id) -> bool {
  613. if (!cached_import_interface_id_.has_value()) {
  614. if (IsSameInterface(import_interface_id, interface_id_)) {
  615. cached_import_interface_id_ = import_interface_id;
  616. return true;
  617. }
  618. } else if (cached_import_interface_id_ == import_interface_id) {
  619. return true;
  620. }
  621. return false;
  622. }
  623. // Returns whether the given interfaces from two different IRs are the same.
  624. auto IsSameInterface(SemIR::InterfaceId import_interface_id,
  625. SemIR::InterfaceId local_interface_id) -> bool {
  626. // The names must be the same.
  627. if (import_ir_->names().GetAsStringIfIdentifier(
  628. import_ir_->interfaces().Get(import_interface_id).name_id) !=
  629. context_->names().GetAsStringIfIdentifier(
  630. context_->interfaces().Get(local_interface_id).name_id)) {
  631. return false;
  632. }
  633. // Compare the interfaces themselves.
  634. // TODO: Should we check the scope of the interface before doing this?
  635. auto local_version_of_import_interface_id =
  636. ImportInterface(*context_, import_ir_id_, import_interface_id);
  637. return local_version_of_import_interface_id == local_interface_id;
  638. }
  639. Context* context_;
  640. // The interface being looked up.
  641. SemIR::InterfaceId interface_id_;
  642. // The IR that we are currently importing impls from.
  643. SemIR::ImportIRId import_ir_id_;
  644. const SemIR::File* import_ir_;
  645. // The interface ID of `interface_id_` in `import_ir_`, if known.
  646. SemIR::InterfaceId cached_import_interface_id_;
  647. };
  648. } // namespace
  649. struct CandidateImpl {
  650. SemIR::ImplId impl_id;
  651. SemIR::InstId loc_inst_id;
  652. // Used for sorting the candidates to find the most-specialized match.
  653. TypeStructure type_structure;
  654. };
  655. // Returns the list of candidates impls for lookup to select from.
  656. static auto CollectCandidateImplsForQuery(
  657. Context& context, bool final_only, SemIR::ConstantId query_self_const_id,
  658. const TypeStructure& query_type_structure,
  659. SemIR::SpecificInterface& query_specific_interface)
  660. -> llvm::SmallVector<CandidateImpl> {
  661. auto import_irs = FindAssociatedImportIRs(context, query_self_const_id,
  662. query_specific_interface);
  663. for (auto import_ir_id : import_irs) {
  664. // Instead of importing all impls, only import ones that are in some way
  665. // connected to this query.
  666. ImportImplFilter filter(context, import_ir_id, query_specific_interface);
  667. for (auto [import_impl_id, _] :
  668. context.import_irs().Get(import_ir_id).sem_ir->impls().enumerate()) {
  669. if (filter.IsRelevantImpl(import_impl_id)) {
  670. // TODO: Track the relevant impls and only consider those ones and any
  671. // local impls, rather than looping over all impls below.
  672. ImportImpl(context, import_ir_id, import_impl_id);
  673. }
  674. }
  675. }
  676. llvm::SmallVector<CandidateImpl> candidate_impls;
  677. for (auto [id, impl] : context.impls().enumerate()) {
  678. if (final_only && !IsImplEffectivelyFinal(context, impl)) {
  679. continue;
  680. }
  681. // If the impl's interface_id differs from the query, then this impl can
  682. // not possibly provide the queried interface.
  683. if (impl.interface.interface_id != query_specific_interface.interface_id) {
  684. continue;
  685. }
  686. // When the impl's interface_id matches, but the interface is generic, the
  687. // impl may or may not match based on restrictions in the generic
  688. // parameters of the impl.
  689. //
  690. // As a shortcut, if the impl's constraint is not symbolic (does not
  691. // depend on any generic parameters), then we can determine whether we match
  692. // by looking if the specific ids match exactly.
  693. auto impl_interface_const_id =
  694. context.constant_values().Get(impl.constraint_id);
  695. if (!impl_interface_const_id.is_symbolic() &&
  696. impl.interface.specific_id != query_specific_interface.specific_id) {
  697. continue;
  698. }
  699. // This check comes first to avoid deduction with an invalid impl. We use
  700. // an error value to indicate an error during creation of the impl, such
  701. // as a recursive impl which will cause deduction to recurse infinitely.
  702. if (impl.witness_id == SemIR::ErrorInst::InstId) {
  703. continue;
  704. }
  705. CARBON_CHECK(impl.witness_id.has_value());
  706. // Build the type structure used for choosing the best the candidate.
  707. auto type_structure =
  708. BuildTypeStructure(context, impl.self_id, impl.interface);
  709. if (!type_structure) {
  710. continue;
  711. }
  712. // TODO: We can skip the comparison here if the `impl_interface_const_id` is
  713. // not symbolic, since when the interface and specific ids match, and they
  714. // aren't symbolic, the structure will be identical.
  715. if (!query_type_structure.CompareStructure(
  716. TypeStructure::CompareTest::IsEqualToOrMoreSpecificThan,
  717. *type_structure)) {
  718. continue;
  719. }
  720. candidate_impls.push_back(
  721. {id, impl.definition_id, std::move(*type_structure)});
  722. }
  723. auto compare = [](auto& lhs, auto& rhs) -> bool {
  724. return lhs.type_structure < rhs.type_structure;
  725. };
  726. // Stable sort is used so that impls that are seen first are preferred when
  727. // they have an equal priority ordering.
  728. // TODO: Allow Carbon code to provide a priority ordering explicitly. For
  729. // now they have all the same priority, so the priority is the order in
  730. // which they are found in code.
  731. llvm::stable_sort(candidate_impls, compare);
  732. return candidate_impls;
  733. }
  734. auto EvalLookupSingleImplWitness(Context& context, SemIR::LocId loc_id,
  735. SemIR::LookupImplWitness eval_query,
  736. SemIR::InstId non_canonical_query_self_inst_id,
  737. bool poison_concrete_results)
  738. -> EvalImplLookupResult {
  739. auto query_specific_interface =
  740. context.specific_interfaces().Get(eval_query.query_specific_interface_id);
  741. auto facet_lookup_result = LookupImplWitnessInSelfFacetValue(
  742. context, non_canonical_query_self_inst_id, query_specific_interface);
  743. if (facet_lookup_result.has_concrete_value()) {
  744. return facet_lookup_result;
  745. }
  746. // If the self type is a facet that provides a witness, then we are in an
  747. // `interface` or an `impl`. In both cases, we don't want to do any impl
  748. // lookups. The query will eventually resolve to a concrete witness when it
  749. // can get it from the self facet value, when it has a specific applied in the
  750. // future.
  751. //
  752. // In particular, this avoids a LookupImplWitness instruction in the eval
  753. // block of an impl declaration from doing impl lookup. Specifically the
  754. // lookup of the implicit .Self in `impl ... where .X`. If it does impl lookup
  755. // when the eval block is run, it finds the same `impl`, tries to build a
  756. // specific from it, which runs the eval block, creating a recursive loop that
  757. // crashes.
  758. bool self_facet_provides_witness = facet_lookup_result.has_value();
  759. if (self_facet_provides_witness) {
  760. if (auto bind = context.insts().TryGetAs<SemIR::BindSymbolicName>(
  761. eval_query.query_self_inst_id)) {
  762. const auto& entity = context.entity_names().Get(bind->entity_name_id);
  763. if (entity.name_id == SemIR::NameId::PeriodSelf ||
  764. entity.name_id == SemIR::NameId::SelfType) {
  765. return EvalImplLookupResult::MakeNonFinal();
  766. }
  767. }
  768. }
  769. SemIR::ConstantId query_self_const_id =
  770. context.constant_values().Get(eval_query.query_self_inst_id);
  771. auto query_type_structure = BuildTypeStructure(
  772. context, context.constant_values().GetInstId(query_self_const_id),
  773. query_specific_interface);
  774. if (!query_type_structure) {
  775. return EvalImplLookupResult::MakeNone();
  776. }
  777. bool query_is_concrete =
  778. QueryIsConcrete(context, query_self_const_id, query_specific_interface);
  779. // If we have a symbolic witness in the self query, then the query can not be
  780. // concrete: the query includes a symbolic self value.
  781. CARBON_CHECK(!self_facet_provides_witness || !query_is_concrete);
  782. // If the self value is a (symbolic) facet value that has a symbolic witness,
  783. // then we don't need to do impl lookup, except that we want to find any final
  784. // impls to return a concrete witness if possible. So we limit the query to
  785. // final impls only in that case. Note as in the CHECK above, the query can
  786. // not be concrete in this case, so only final impls can produce a concrete
  787. // witness for this query.
  788. auto candidate_impls = CollectCandidateImplsForQuery(
  789. context, self_facet_provides_witness, query_self_const_id,
  790. *query_type_structure, query_specific_interface);
  791. for (const auto& candidate : candidate_impls) {
  792. // In deferred lookup for a symbolic impl witness, while building a
  793. // specific, there may be no stack yet as this may be the first lookup. If
  794. // further lookups are started as a result in deduce, they will build the
  795. // stack.
  796. //
  797. // NOTE: Don't retain a reference into the stack, it may be invalidated if
  798. // we do further impl lookups when GetWitnessIdForImpl() does deduction.
  799. if (!context.impl_lookup_stack().empty()) {
  800. context.impl_lookup_stack().back().impl_loc = candidate.loc_inst_id;
  801. }
  802. auto result = GetWitnessIdForImpl(
  803. context, loc_id, query_is_concrete, query_self_const_id,
  804. query_specific_interface, candidate.impl_id);
  805. if (result.has_value()) {
  806. // Record the query which found a concrete impl witness. It's illegal to
  807. // write a final impl afterward that would match the same query.
  808. //
  809. // If the impl was effectively final, then we don't need to poison here. A
  810. // change of query result will already be diagnosed at the point where the
  811. // new impl decl was written that changes the result.
  812. if (poison_concrete_results && result.has_concrete_value() &&
  813. !IsImplEffectivelyFinal(context,
  814. context.impls().Get(candidate.impl_id))) {
  815. context.poisoned_concrete_impl_lookup_queries().push_back(
  816. {.loc_id = loc_id,
  817. .query = eval_query,
  818. .non_canonical_query_self_inst_id =
  819. non_canonical_query_self_inst_id,
  820. .impl_witness = result.concrete_witness()});
  821. }
  822. return result;
  823. }
  824. }
  825. if (self_facet_provides_witness) {
  826. // If we did not find a final impl, but the self value is a facet that
  827. // provides a symbolic witness, when we record that an impl will exist for
  828. // the specific, but is yet unknown.
  829. return EvalImplLookupResult::MakeNonFinal();
  830. }
  831. return EvalImplLookupResult::MakeNone();
  832. }
  833. auto LookupMatchesImpl(Context& context, SemIR::LocId loc_id,
  834. SemIR::ConstantId query_self_const_id,
  835. SemIR::SpecificInterface query_specific_interface,
  836. SemIR::ImplId target_impl) -> bool {
  837. if (query_self_const_id == SemIR::ErrorInst::ConstantId) {
  838. return false;
  839. }
  840. auto result = GetWitnessIdForImpl(
  841. context, loc_id, /*query_is_concrete=*/false, query_self_const_id,
  842. query_specific_interface, target_impl);
  843. return result.has_value();
  844. }
  845. } // namespace Carbon::Check