check_unit.cpp 24 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604
  1. // Part of the Carbon Language project, under the Apache License v2.0 with LLVM
  2. // Exceptions. See /LICENSE for license information.
  3. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
  4. #include "toolchain/check/check_unit.h"
  5. #include <iterator>
  6. #include <string>
  7. #include <tuple>
  8. #include <utility>
  9. #include "llvm/ADT/IntrusiveRefCntPtr.h"
  10. #include "llvm/ADT/StringRef.h"
  11. #include "llvm/Support/VirtualFileSystem.h"
  12. #include "toolchain/base/kind_switch.h"
  13. #include "toolchain/base/pretty_stack_trace_function.h"
  14. #include "toolchain/check/diagnostic_helpers.h"
  15. #include "toolchain/check/generic.h"
  16. #include "toolchain/check/handle.h"
  17. #include "toolchain/check/impl.h"
  18. #include "toolchain/check/impl_lookup.h"
  19. #include "toolchain/check/impl_validation.h"
  20. #include "toolchain/check/import.h"
  21. #include "toolchain/check/import_cpp.h"
  22. #include "toolchain/check/import_ref.h"
  23. #include "toolchain/check/inst.h"
  24. #include "toolchain/check/node_id_traversal.h"
  25. #include "toolchain/check/type.h"
  26. #include "toolchain/check/type_structure.h"
  27. #include "toolchain/diagnostics/diagnostic.h"
  28. #include "toolchain/sem_ir/function.h"
  29. #include "toolchain/sem_ir/ids.h"
  30. #include "toolchain/sem_ir/import_ir.h"
  31. #include "toolchain/sem_ir/typed_insts.h"
  32. namespace Carbon::Check {
  33. // Returns the number of imported IRs, to assist in Context construction.
  34. static auto GetImportedIRCount(UnitAndImports* unit_and_imports) -> int {
  35. int count = 0;
  36. for (auto& package_imports : unit_and_imports->package_imports) {
  37. count += package_imports.imports.size();
  38. }
  39. if (!unit_and_imports->api_for_impl) {
  40. // Leave an empty slot for `ImportIRId::ApiForImpl`.
  41. ++count;
  42. }
  43. if (!unit_and_imports->cpp_import_names.empty()) {
  44. // Leave an empty slot for `ImportIRId::Cpp`.
  45. ++count;
  46. }
  47. return count;
  48. }
  49. CheckUnit::CheckUnit(
  50. UnitAndImports* unit_and_imports,
  51. llvm::ArrayRef<Parse::GetTreeAndSubtreesFn> tree_and_subtrees_getters,
  52. llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> fs, llvm::StringRef target,
  53. llvm::raw_ostream* vlog_stream)
  54. : unit_and_imports_(unit_and_imports),
  55. tree_and_subtrees_getter_(
  56. tree_and_subtrees_getters
  57. [unit_and_imports->unit->sem_ir->check_ir_id().index]),
  58. total_ir_count_(tree_and_subtrees_getters.size()),
  59. fs_(std::move(fs)),
  60. target_(target),
  61. vlog_stream_(vlog_stream),
  62. emitter_(&unit_and_imports_->err_tracker, tree_and_subtrees_getters,
  63. unit_and_imports_->unit->sem_ir),
  64. context_(
  65. &emitter_, tree_and_subtrees_getter_, unit_and_imports_->unit->sem_ir,
  66. GetImportedIRCount(unit_and_imports), total_ir_count_, vlog_stream) {}
  67. auto CheckUnit::Run() -> void {
  68. Timings::ScopedTiming timing(unit_and_imports_->unit->timings, "check");
  69. // We can safely mark this as checked at the start.
  70. unit_and_imports_->is_checked = true;
  71. PrettyStackTraceFunction context_dumper(
  72. [&](llvm::raw_ostream& output) { context_.PrintForStackDump(output); });
  73. // Add a block for the file.
  74. context_.inst_block_stack().Push();
  75. InitPackageScopeAndImports();
  76. // Eagerly import the impls declared in the api file to prepare to redeclare
  77. // them.
  78. ImportImplsFromApiFile(context_);
  79. if (!ProcessNodeIds()) {
  80. context_.sem_ir().set_has_errors(true);
  81. return;
  82. }
  83. FinishRun();
  84. }
  85. auto CheckUnit::InitPackageScopeAndImports() -> void {
  86. // Importing makes many namespaces, so only canonicalize the type once.
  87. auto namespace_type_id =
  88. GetSingletonType(context_, SemIR::NamespaceType::TypeInstId);
  89. // Define the package scope, with an instruction for `package` expressions to
  90. // reference.
  91. auto package_scope_id = context_.name_scopes().Add(
  92. SemIR::Namespace::PackageInstId, SemIR::NameId::PackageNamespace,
  93. SemIR::NameScopeId::None);
  94. CARBON_CHECK(package_scope_id == SemIR::NameScopeId::Package);
  95. auto package_inst_id =
  96. AddInst<SemIR::Namespace>(context_, Parse::NodeId::None,
  97. {.type_id = namespace_type_id,
  98. .name_scope_id = SemIR::NameScopeId::Package,
  99. .import_id = SemIR::InstId::None});
  100. CARBON_CHECK(package_inst_id == SemIR::Namespace::PackageInstId);
  101. // Call `SetSpecialImportIRs()` to set `ImportIRId::ApiForImpl` and
  102. // `ImportIRId::Cpp` first, as required.
  103. if (unit_and_imports_->api_for_impl) {
  104. const auto& names = context_.parse_tree().packaging_decl()->names;
  105. auto import_decl_id = AddInst<SemIR::ImportDecl>(
  106. context_, names.node_id,
  107. {.package_id = SemIR::NameId::ForPackageName(names.package_id)});
  108. SetSpecialImportIRs(
  109. context_, {.decl_id = import_decl_id,
  110. .is_export = false,
  111. .sem_ir = unit_and_imports_->api_for_impl->unit->sem_ir});
  112. } else {
  113. SetSpecialImportIRs(context_,
  114. {.decl_id = SemIR::InstId::None, .sem_ir = nullptr});
  115. }
  116. // Add import instructions for everything directly imported. Implicit imports
  117. // are handled separately.
  118. for (auto& package_imports : unit_and_imports_->package_imports) {
  119. CARBON_CHECK(!package_imports.import_decl_id.has_value());
  120. package_imports.import_decl_id = AddInst<SemIR::ImportDecl>(
  121. context_, package_imports.node_id,
  122. {.package_id =
  123. SemIR::NameId::ForPackageName(package_imports.package_id)});
  124. }
  125. // Process the imports.
  126. if (unit_and_imports_->api_for_impl) {
  127. ImportApiFile(context_, namespace_type_id,
  128. *unit_and_imports_->api_for_impl->unit->sem_ir);
  129. }
  130. ImportCurrentPackage(package_inst_id, namespace_type_id);
  131. CARBON_CHECK(context_.scope_stack().PeekIndex() == ScopeIndex::Package);
  132. ImportOtherPackages(namespace_type_id);
  133. const auto& cpp_import_names = unit_and_imports_->cpp_import_names;
  134. if (!cpp_import_names.empty()) {
  135. auto* cpp_ast = unit_and_imports_->unit->cpp_ast;
  136. CARBON_CHECK(cpp_ast);
  137. CARBON_CHECK(!cpp_ast->get());
  138. *cpp_ast =
  139. ImportCppFiles(context_, unit_and_imports_->unit->sem_ir->filename(),
  140. cpp_import_names, fs_, target_);
  141. }
  142. }
  143. auto CheckUnit::CollectDirectImports(
  144. llvm::SmallVector<SemIR::ImportIR>& results,
  145. llvm::MutableArrayRef<int> ir_to_result_index, SemIR::InstId import_decl_id,
  146. const PackageImports& imports, bool is_local) -> void {
  147. for (const auto& import : imports.imports) {
  148. const auto& direct_ir = *import.unit_info->unit->sem_ir;
  149. auto& index = ir_to_result_index[direct_ir.check_ir_id().index];
  150. if (index != -1) {
  151. // This should only happen when doing API imports for an implementation
  152. // file. Don't change the entry; is_export doesn't matter.
  153. continue;
  154. }
  155. index = results.size();
  156. results.push_back({.decl_id = import_decl_id,
  157. // Only tag exports in API files, ignoring the value in
  158. // implementation files.
  159. .is_export = is_local && import.names.is_export,
  160. .sem_ir = &direct_ir});
  161. }
  162. }
  163. auto CheckUnit::CollectTransitiveImports(SemIR::InstId import_decl_id,
  164. const PackageImports* local_imports,
  165. const PackageImports* api_imports)
  166. -> llvm::SmallVector<SemIR::ImportIR> {
  167. llvm::SmallVector<SemIR::ImportIR> results;
  168. // Track whether an IR was imported in full, including `export import`. This
  169. // distinguishes from IRs that are indirectly added without all names being
  170. // exported to this IR.
  171. llvm::SmallVector<int> ir_to_result_index(total_ir_count_, -1);
  172. // First add direct imports. This means that if an entity is imported both
  173. // directly and indirectly, the import path will reflect the direct import.
  174. if (local_imports) {
  175. CollectDirectImports(results, ir_to_result_index, import_decl_id,
  176. *local_imports,
  177. /*is_local=*/true);
  178. }
  179. if (api_imports) {
  180. CollectDirectImports(results, ir_to_result_index, import_decl_id,
  181. *api_imports,
  182. /*is_local=*/false);
  183. }
  184. // Loop through direct imports for any indirect exports. The underlying vector
  185. // is appended during iteration, so take the size first.
  186. const int direct_imports = results.size();
  187. for (int direct_index : llvm::seq(direct_imports)) {
  188. bool is_export = results[direct_index].is_export;
  189. for (const auto& indirect_ir :
  190. results[direct_index].sem_ir->import_irs().array_ref()) {
  191. if (!indirect_ir.is_export) {
  192. continue;
  193. }
  194. auto& indirect_index =
  195. ir_to_result_index[indirect_ir.sem_ir->check_ir_id().index];
  196. if (indirect_index == -1) {
  197. indirect_index = results.size();
  198. // TODO: In the case of a recursive `export import`, this only points at
  199. // the outermost import. May want something that better reflects the
  200. // recursion.
  201. results.push_back({.decl_id = results[direct_index].decl_id,
  202. .is_export = is_export,
  203. .sem_ir = indirect_ir.sem_ir});
  204. } else if (is_export) {
  205. results[indirect_index].is_export = true;
  206. }
  207. }
  208. }
  209. return results;
  210. }
  211. auto CheckUnit::ImportCurrentPackage(SemIR::InstId package_inst_id,
  212. SemIR::TypeId namespace_type_id) -> void {
  213. // Add imports from the current package.
  214. auto import_map_lookup =
  215. unit_and_imports_->package_imports_map.Lookup(PackageNameId::None);
  216. if (!import_map_lookup) {
  217. // Push the scope; there are no names to add.
  218. context_.scope_stack().PushForEntity(
  219. package_inst_id, SemIR::NameScopeId::Package, SemIR::SpecificId::None,
  220. /*lexical_lookup_has_load_error=*/false);
  221. return;
  222. }
  223. PackageImports& self_import =
  224. unit_and_imports_->package_imports[import_map_lookup.value()];
  225. if (self_import.has_load_error) {
  226. context_.name_scopes().Get(SemIR::NameScopeId::Package).set_has_error();
  227. }
  228. ImportLibrariesFromCurrentPackage(
  229. context_, namespace_type_id,
  230. CollectTransitiveImports(self_import.import_decl_id, &self_import,
  231. /*api_imports=*/nullptr));
  232. context_.scope_stack().PushForEntity(
  233. package_inst_id, SemIR::NameScopeId::Package, SemIR::SpecificId::None,
  234. context_.name_scopes().Get(SemIR::NameScopeId::Package).has_error());
  235. }
  236. auto CheckUnit::ImportOtherPackages(SemIR::TypeId namespace_type_id) -> void {
  237. // api_imports_list is initially the size of the current file's imports,
  238. // including for API files, for simplicity in iteration. It's only really used
  239. // when processing an implementation file, in order to combine the API file
  240. // imports.
  241. //
  242. // For packages imported by the API file, the PackageNameId is the package
  243. // name and the index is into the API's import list. Otherwise, the initial
  244. // {None, -1} state remains.
  245. llvm::SmallVector<std::pair<PackageNameId, int32_t>> api_imports_list;
  246. api_imports_list.resize(unit_and_imports_->package_imports.size(),
  247. {PackageNameId::None, -1});
  248. // When there's an API file, add the mapping to api_imports_list.
  249. if (unit_and_imports_->api_for_impl) {
  250. const auto& api_identifiers =
  251. unit_and_imports_->api_for_impl->unit->value_stores->identifiers();
  252. auto& impl_identifiers =
  253. unit_and_imports_->unit->value_stores->identifiers();
  254. for (auto [api_imports_index, api_imports] :
  255. llvm::enumerate(unit_and_imports_->api_for_impl->package_imports)) {
  256. // Skip the current package.
  257. if (!api_imports.package_id.has_value()) {
  258. continue;
  259. }
  260. // Translate the package ID from the API file to the implementation file.
  261. auto impl_package_id = api_imports.package_id;
  262. if (auto package_identifier_id = impl_package_id.AsIdentifierId();
  263. package_identifier_id.has_value()) {
  264. impl_package_id = PackageNameId::ForIdentifier(
  265. impl_identifiers.Add(api_identifiers.Get(package_identifier_id)));
  266. }
  267. if (auto lookup =
  268. unit_and_imports_->package_imports_map.Lookup(impl_package_id)) {
  269. // On a hit, replace the entry to unify the API and implementation
  270. // imports.
  271. api_imports_list[lookup.value()] = {impl_package_id, api_imports_index};
  272. } else {
  273. // On a miss, add the package as API-only.
  274. api_imports_list.push_back({impl_package_id, api_imports_index});
  275. }
  276. }
  277. }
  278. for (auto [i, api_imports_entry] : llvm::enumerate(api_imports_list)) {
  279. // These variables are updated after figuring out which imports are present.
  280. auto import_decl_id = SemIR::InstId::None;
  281. PackageNameId package_id = PackageNameId::None;
  282. bool has_load_error = false;
  283. // Identify the local package imports if present.
  284. PackageImports* local_imports = nullptr;
  285. if (i < unit_and_imports_->package_imports.size()) {
  286. local_imports = &unit_and_imports_->package_imports[i];
  287. if (!local_imports->package_id.has_value()) {
  288. // Skip the current package.
  289. continue;
  290. }
  291. import_decl_id = local_imports->import_decl_id;
  292. package_id = local_imports->package_id;
  293. has_load_error |= local_imports->has_load_error;
  294. }
  295. // Identify the API package imports if present.
  296. PackageImports* api_imports = nullptr;
  297. if (api_imports_entry.second != -1) {
  298. api_imports = &unit_and_imports_->api_for_impl
  299. ->package_imports[api_imports_entry.second];
  300. if (local_imports) {
  301. CARBON_CHECK(package_id == api_imports_entry.first);
  302. } else {
  303. auto import_ir_inst_id =
  304. context_.import_ir_insts().Add(SemIR::ImportIRInst(
  305. SemIR::ImportIRId::ApiForImpl, api_imports->import_decl_id));
  306. import_decl_id =
  307. AddInst(context_, MakeImportedLocIdAndInst<SemIR::ImportDecl>(
  308. context_, import_ir_inst_id,
  309. {.package_id = SemIR::NameId::ForPackageName(
  310. api_imports_entry.first)}));
  311. package_id = api_imports_entry.first;
  312. }
  313. has_load_error |= api_imports->has_load_error;
  314. }
  315. // Do the actual import.
  316. ImportLibrariesFromOtherPackage(
  317. context_, namespace_type_id, import_decl_id, package_id,
  318. CollectTransitiveImports(import_decl_id, local_imports, api_imports),
  319. has_load_error);
  320. }
  321. }
  322. // Loops over all nodes in the tree. On some errors, this may return early,
  323. // for example if an unrecoverable state is encountered.
  324. // NOLINTNEXTLINE(readability-function-size)
  325. auto CheckUnit::ProcessNodeIds() -> bool {
  326. NodeIdTraversal traversal(&context_, vlog_stream_);
  327. Parse::NodeId node_id = Parse::NodeId::None;
  328. // On crash, report which token we were handling.
  329. PrettyStackTraceFunction node_dumper([&](llvm::raw_ostream& output) {
  330. const auto& tree = tree_and_subtrees_getter_();
  331. auto converted = tree.NodeToDiagnosticLoc(node_id, /*token_only=*/false);
  332. converted.loc.FormatLocation(output);
  333. output << "checking " << context_.parse_tree().node_kind(node_id) << "\n";
  334. // Crash output has a tab indent; try to indent slightly past that.
  335. converted.loc.FormatSnippet(output, /*indent=*/10);
  336. });
  337. while (auto maybe_node_id = traversal.Next()) {
  338. node_id = *maybe_node_id;
  339. emitter_.AdvanceToken(context_.parse_tree().node_token(node_id));
  340. if (context_.parse_tree().node_has_error(node_id)) {
  341. context_.TODO(node_id, "handle invalid parse trees in `check`");
  342. return false;
  343. }
  344. bool result;
  345. auto parse_kind = context_.parse_tree().node_kind(node_id);
  346. switch (parse_kind) {
  347. #define CARBON_PARSE_NODE_KIND(Name) \
  348. case Parse::NodeKind::Name: { \
  349. result = HandleParseNode( \
  350. context_, context_.parse_tree().As<Parse::Name##Id>(node_id)); \
  351. break; \
  352. }
  353. #include "toolchain/parse/node_kind.def"
  354. }
  355. if (!result) {
  356. CARBON_CHECK(
  357. unit_and_imports_->err_tracker.seen_error(),
  358. "HandleParseNode for `{0}` returned false without diagnosing.",
  359. parse_kind);
  360. return false;
  361. }
  362. traversal.Handle(parse_kind);
  363. }
  364. return true;
  365. }
  366. auto CheckUnit::CheckRequiredDeclarations() -> void {
  367. for (const auto& function : context_.functions().array_ref()) {
  368. if (!function.first_owning_decl_id.has_value() &&
  369. function.extern_library_id == context_.sem_ir().library_id()) {
  370. auto function_import_id =
  371. context_.insts().GetImportSource(function.non_owning_decl_id);
  372. CARBON_CHECK(function_import_id.has_value());
  373. auto import_ir_id =
  374. context_.sem_ir().import_ir_insts().Get(function_import_id).ir_id();
  375. auto& import_ir = context_.import_irs().Get(import_ir_id);
  376. if (import_ir.sem_ir->package_id().has_value() !=
  377. context_.sem_ir().package_id().has_value()) {
  378. continue;
  379. }
  380. CARBON_DIAGNOSTIC(
  381. MissingOwningDeclarationInApi, Error,
  382. "owning declaration required for non-owning declaration");
  383. if (!import_ir.sem_ir->package_id().has_value() &&
  384. !context_.sem_ir().package_id().has_value()) {
  385. emitter_.Emit(function.non_owning_decl_id,
  386. MissingOwningDeclarationInApi);
  387. continue;
  388. }
  389. if (import_ir.sem_ir->identifiers().Get(
  390. import_ir.sem_ir->package_id().AsIdentifierId()) ==
  391. context_.sem_ir().identifiers().Get(
  392. context_.sem_ir().package_id().AsIdentifierId())) {
  393. emitter_.Emit(function.non_owning_decl_id,
  394. MissingOwningDeclarationInApi);
  395. }
  396. }
  397. }
  398. }
  399. auto CheckUnit::CheckRequiredDefinitions() -> void {
  400. CARBON_DIAGNOSTIC(MissingDefinitionInImpl, Error,
  401. "no definition found for declaration in impl file");
  402. // Note that more required definitions can be added during this loop.
  403. // NOLINTNEXTLINE(modernize-loop-convert)
  404. for (size_t i = 0; i != context_.definitions_required_by_decl().size(); ++i) {
  405. SemIR::InstId decl_inst_id = context_.definitions_required_by_decl()[i];
  406. SemIR::Inst decl_inst = context_.insts().Get(decl_inst_id);
  407. CARBON_KIND_SWITCH(context_.insts().Get(decl_inst_id)) {
  408. case CARBON_KIND(SemIR::ClassDecl class_decl): {
  409. if (!context_.classes().Get(class_decl.class_id).is_complete()) {
  410. emitter_.Emit(decl_inst_id, MissingDefinitionInImpl);
  411. }
  412. break;
  413. }
  414. case CARBON_KIND(SemIR::FunctionDecl function_decl): {
  415. if (context_.functions().Get(function_decl.function_id).definition_id ==
  416. SemIR::InstId::None) {
  417. emitter_.Emit(decl_inst_id, MissingDefinitionInImpl);
  418. }
  419. break;
  420. }
  421. case CARBON_KIND(SemIR::ImplDecl impl_decl): {
  422. auto& impl = context_.impls().Get(impl_decl.impl_id);
  423. if (!impl.is_complete()) {
  424. FillImplWitnessWithErrors(context_, impl);
  425. CARBON_DIAGNOSTIC(ImplMissingDefinition, Error,
  426. "impl declared but not defined");
  427. emitter_.Emit(decl_inst_id, ImplMissingDefinition);
  428. }
  429. break;
  430. }
  431. case SemIR::InterfaceDecl::Kind: {
  432. // TODO: Handle `interface` as well, once we can test it without
  433. // triggering
  434. // https://github.com/carbon-language/carbon-lang/issues/4071.
  435. CARBON_FATAL("TODO: Support interfaces in DiagnoseMissingDefinitions");
  436. }
  437. default: {
  438. CARBON_FATAL("Unexpected inst in definitions_required_by_decl: {0}",
  439. decl_inst);
  440. }
  441. }
  442. }
  443. // Note that more required definitions can be added during this loop.
  444. // NOLINTNEXTLINE(modernize-loop-convert)
  445. for (size_t i = 0; i != context_.definitions_required_by_use().size(); ++i) {
  446. // This is using the location for the use. We could track the
  447. // list of enclosing locations if this was used from a generic.
  448. auto [loc, specific_id] = context_.definitions_required_by_use()[i];
  449. if (!ResolveSpecificDefinition(context_, loc, specific_id)) {
  450. CARBON_DIAGNOSTIC(MissingGenericFunctionDefinition, Error,
  451. "use of undefined generic function");
  452. CARBON_DIAGNOSTIC(MissingGenericFunctionDefinitionHere, Note,
  453. "generic function declared here");
  454. auto generic_decl_id =
  455. context_.generics()
  456. .Get(context_.specifics().Get(specific_id).generic_id)
  457. .decl_id;
  458. emitter_.Build(loc, MissingGenericFunctionDefinition)
  459. .Note(generic_decl_id, MissingGenericFunctionDefinitionHere)
  460. .Emit();
  461. }
  462. }
  463. }
  464. auto CheckUnit::CheckPoisonedConcreteImplLookupQueries() -> void {
  465. // Impl lookup can generate instructions (via deduce) which we don't use, as
  466. // we're only generating diagnostics here, so we catch and discard them.
  467. context_.inst_block_stack().Push();
  468. auto poisoned_queries =
  469. std::exchange(context_.poisoned_concrete_impl_lookup_queries(), {});
  470. for (const auto& poison : poisoned_queries) {
  471. auto witness_result =
  472. EvalLookupSingleImplWitness(context_, poison.loc_id, poison.query,
  473. poison.non_canonical_query_self_inst_id,
  474. /*poison_concrete_results=*/false);
  475. CARBON_CHECK(witness_result.has_concrete_value());
  476. auto found_witness_id = witness_result.concrete_witness();
  477. if (found_witness_id != poison.impl_witness) {
  478. auto witness_to_impl_id = [&](SemIR::InstId witness_id) {
  479. auto table_id = context_.insts()
  480. .GetAs<SemIR::ImplWitness>(witness_id)
  481. .witness_table_id;
  482. return context_.insts()
  483. .GetAs<SemIR::ImplWitnessTable>(table_id)
  484. .impl_id;
  485. };
  486. // We can get the `Impl` from the resulting witness here, which is the
  487. // `Impl` that conflicts with the previous poison query.
  488. auto bad_impl_id = witness_to_impl_id(found_witness_id);
  489. const auto& bad_impl = context_.impls().Get(bad_impl_id);
  490. auto prev_impl_id = witness_to_impl_id(poison.impl_witness);
  491. const auto& prev_impl = context_.impls().Get(prev_impl_id);
  492. CARBON_DIAGNOSTIC(
  493. PoisonedImplLookupConcreteResult, Error,
  494. "found `impl` that would change the result of an earlier "
  495. "use of `{0} as {1}`",
  496. InstIdAsRawType, SpecificInterfaceIdAsRawType);
  497. auto builder =
  498. emitter_.Build(poison.loc_id, PoisonedImplLookupConcreteResult,
  499. poison.query.query_self_inst_id,
  500. poison.query.query_specific_interface_id);
  501. CARBON_DIAGNOSTIC(
  502. PoisonedImplLookupConcreteResultNoteBadImpl, Note,
  503. "the use would select the `impl` here but it was not found yet");
  504. builder.Note(bad_impl.first_decl_id(),
  505. PoisonedImplLookupConcreteResultNoteBadImpl);
  506. CARBON_DIAGNOSTIC(PoisonedImplLookupConcreteResultNotePreviousImpl, Note,
  507. "the use had selected the `impl` here");
  508. builder.Note(prev_impl.first_decl_id(),
  509. PoisonedImplLookupConcreteResultNotePreviousImpl);
  510. builder.Emit();
  511. }
  512. }
  513. context_.inst_block_stack().PopAndDiscard();
  514. }
  515. auto CheckUnit::CheckImpls() -> void { ValidateImplsInFile(context_); }
  516. auto CheckUnit::FinishRun() -> void {
  517. CheckRequiredDeclarations();
  518. CheckRequiredDefinitions();
  519. CheckPoisonedConcreteImplLookupQueries();
  520. CheckImpls();
  521. // Pop information for the file-level scope.
  522. context_.sem_ir().set_top_inst_block_id(context_.inst_block_stack().Pop());
  523. context_.scope_stack().Pop();
  524. // Finalizes the list of exports on the IR.
  525. context_.inst_blocks().ReplacePlaceholder(SemIR::InstBlockId::Exports,
  526. context_.exports());
  527. // Finalizes the ImportRef inst block.
  528. context_.inst_blocks().ReplacePlaceholder(SemIR::InstBlockId::ImportRefs,
  529. context_.import_ref_ids());
  530. // Finalizes __global_init.
  531. context_.global_init().Finalize();
  532. context_.sem_ir().set_has_errors(unit_and_imports_->err_tracker.seen_error());
  533. // Verify that Context cleanly finished.
  534. context_.VerifyOnFinish();
  535. }
  536. } // namespace Carbon::Check